-
-
Notifications
You must be signed in to change notification settings - Fork 4
Implement GPT support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly LGTM (also scooped me, nice), got a few minor nits is all
also if you want and run out of time for this I can work on any finishing stuff |
Would appreciate that! Sorry for stepping on your toes a bit with this btw, I'd written it a few weeks ago but had been too busy to make the PR >_< |
no worries, you got a heck of a lot further than i did |
addressed the nits and pushed an update to the PR |
Also make sure not to merge this before we have some tests. I'll write some up in a couple of days if you don't get to it first :) |
I'll also be switching my os over to this pr branch at some point in a few days to try it out in a real scenario |
A few things need doing before this is good to merge:
Really the GPT code should call into the MBR code to make the protective MBR. I can have a look in a few days at making this change, but happy for someone else to if they get to it before I do.I forgot I already did this.The code might not compile since as I was working on master. I think I've made sure the code is right now, but be sure that they are correct before merging :)