-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide effects on supported Philips Hue lights #355
base: dev
Are you sure you want to change the base?
Conversation
Test asserts are failing, but seem to be correct - tests will need to be changed. All lights that provide cluster 0xFC03 are failing, while those missing it (e.g. |
You can delete the JSON test files for now then. We'll eventually regenerate and upload them again. |
e5b8630
to
00a3125
Compare
@TheJulianJES I pushed changes to match the last renaming from quirk PR. I haven't resolved the failing tests yet as I lost track which JSONs were problematic, but I realized I also don't know why they were failing in the first place. Given that I had old cluster name, even if the quirk PR got already picked up during tests, my class shouldn't have matched any device yet. I've added |
Hi @TheJulianJES, just wondering if you were able to provide any feedback on the above? |
Description
Adds additional effects to supported Philips Hue lights. To control the effects, commands are sent to a exposed cluster.
Implements HA / UI portion of zigpy/zha-device-handlers#2517, which contains detailed discussion.
The effect is turned on by command 0x22 that accepts brightness and the effect ID.
To turn off, command 0x20 is used that will preserve most recent color and brightness while stopping further effect execution.
Testing
Tested with Philips Hue Go. See video below:
https://github.com/user-attachments/assets/9d6236f6-4d8f-40ee-8525-82e674d4ca85
Prerequisite
PR implementing quirk for the Philips cluster: zigpy/zha-device-handlers#2517