Ensure a cover's supported features and attributes are respective of its window covering type attribute #410
+151
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct window_covering_type
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #410 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 61 61
Lines 9834 9838 +4
=======================================
+ Hits 9508 9512 +4
Misses 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…current_position properties
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
90f300b to
aab8119
Compare
Apply pre-commit auto fixes
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
aab8119 to
d9cfa64
Compare
jeverley
changed the title
jeverley
changed the title
- Also use them in the tests rather than defining them separately
jeverley
force-pushed
the
cover-handle-lift-only-devices-reporting-tilt-position
branch
from
dc502ce to
5953d0f
Compare
puddly
reviewed
Apr 8, 2025
| @@ -669,7 +676,7 @@ def state(self) -> dict[str, Any]: | |||
| @functools.cached_property | |||
| def supported_features(self) -> CoverEntityFeature: | |||
| """Return supported features.""" | |||
| return self._attr_supported_features | |||
There was a problem hiding this comment.
For consistency with the other platforms and attributes, let's keep the _attr prefix for now. These are meant to mirror those in Home Assistant: https://github.com/home-assistant/core/blob/3aae280de50a92cdfcf5c04b088fe9178fba0b2e/homeassistant/components/cover/__init__.py#L240
There was a problem hiding this comment.
Hey @puddly, I've reverted the naming to include the _attr prefix, I've also adjusted the recompute_capabilities method so that it only updates the final value after evaluating all criteria.
puddly
reviewed
Apr 8, 2025
jeverley
added a commit
to jeverley/zha
that referenced
this pull request
Apr 9, 2025
…e HA cache This adds a timeout for movement states restored from the entity cache. Uses zigpy#410 as a base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
current_positionandcurrent_tilt_positionstate attributes now reportNoneif their features are not supported by the device, resolves #142352supported_featureslogic so it excludes tilt only window covering types when enabling lift featureswindow_covering_typeattribute value is undefined by the deviceWCT.ShutterorWCT.Tilt_blind_tilt_onlytypes, see Table 7-41. Window Covering Type from the Cluster Library Specification 07-5123 Revision 8current_tilt_positionis always Nonecurrent_positionis always NoneFixes issue
Zigbee Soma Smart Shades 3 covers report OPEN state when closed home-assistant/core#142352
Related
FYI @TheJulianJES, @puddly, @dmulcahey