Use quirks v2 exposed features #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJulianJES
commented
Nov 26, 2025
tests/test_device.py
Outdated
Comment on lines
1154
to
1158
| # can access the quirk metadata for config features for now | ||
| assert zha_device.quirk_metadata.exposes_features == ( | ||
| ExposesFeatureMetadata(feature="some_feature"), | ||
| ExposesFeatureMetadata(feature="another_feature", config={"option": True}), | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
We can access the config parameters using the quirk_metadata for now.
In the future, we can consider changing the device.exposes_features from a set[str] to something else, but as we don't need the config options at this very moment, it's something we can do later.
Not sure in how many situations this is an issue anyway.
TheJulianJES
force-pushed
the
tjj/quirks_v2_exposed_features
branch
from
c03d970 to
046b34c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #586 +/- ##
==========================================
+ Coverage 96.96% 96.97% +0.01%
==========================================
Files 63 63
Lines 10553 10555 +2
==========================================
+ Hits 10233 10236 +3
+ Misses 320 319 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds the quirks v2 exposed features to the
device.exposed_featuresset[str].Related:
quirk_idtoexposes_features+ allow multiple features #575configfor exposed features zigpy#1712