MON-322 add reranking benchmark#574
Open
dommonkhouse wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reranker.model, including plain-mode isolation from global reranker config.Test Plan
env -u MEMSEARCH_DIR uv run python -m pytest -quv run ruff check src tests scriptsuv run ruff format --check src tests scriptsuv run python scripts/benchmark_reranking.py --fixture-dir tests/fixtures/reranking --queries tests/fixtures/reranking/benchmark.json --collection ms_memsearch_ae2d4f9b --top-k 5 --reranker-model Alibaba-NLP/gte-reranker-modernbert-base --out /tmp/memsearch-reranking-fixture.jsonNotes
MEMSEARCH_DIRis cleared for pytest because the local shell sets it to a live shared state directory; leaving it set causes unrelated maintenance tests to share state.