Skip to content

fix: Undefined symbols in milvus::tracer::AutoSpan::AutoSpan #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhmo merged 1 commit into from
Jun 30, 2026
Merged

fix: Undefined symbols in milvus::tracer::AutoSpan::AutoSpan #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/common/Tracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@
#include "opentelemetry/trace/span_id.h"
#include "opentelemetry/trace/trace_id.h"

namespace opentelemetry::trace {
OPENTELEMETRY_BEGIN_NAMESPACE
namespace trace {
class Span;
class Tracer;
} // namespace opentelemetry::trace
} // namespace trace
OPENTELEMETRY_END_NAMESPACE

#define TRACE_SERVICE_SEGCORE "segcore"

Expand Down
6 changes: 6 additions & 0 deletions test/TracerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ TEST(Tracer, Span) {
delete[] ctx->spanID;
}

TEST(Tracer, AutoSpanParentConstructorUsesHeaderDeclaredSpanType) {
std::shared_ptr<milvus::tracer::trace::Span> parent;
AutoSpan span("header_abi_parent", parent, false);
ASSERT_NE(span.GetSpan(), nullptr);
}

TEST(Tracer, OwnedTraceSnapshotCopiesBytes) {
uint8_t trace_id[16]{0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef,
0xfe, 0xdc, 0xba, 0x98, 0x76, 0x54, 0x32, 0x10};
Expand Down
Loading