feat: [NCS] Add Near-Compute Storage (NCS) core infrastructure#54
Open
ronmarcus wants to merge 3 commits into
Open
feat: [NCS] Add Near-Compute Storage (NCS) core infrastructure#54ronmarcus wants to merge 3 commits into
ronmarcus wants to merge 3 commits into
Conversation
added 2 commits
January 1, 2026 17:24
This commit introduces the core infrastructure for Near-Compute Storage (NCS), a shared hot storage tier designed to decouple compute and storage in Milvus. Key changes: - Added `NcsSingleton`, `NcsFactory`, and `NcsConnector` interfaces to abstract storage backends. - Implemented `InMemoryNcs` and `InMemNcsConnector` backed by `InMemoryKV` for testing. - Implemented `RedisNcs` and `RedisNcsConnector` as a reference remote storage backend. - Exposed C-compatible API (`ncs_c.h`) to allow integration with the Milvus Go control plane. - Added unit tests for both In-Memory and Redis implementations. This infrastructure enables upper layers (Knowhere, Milvus) to interact with disaggregated storage through a unified Key-Value API. issue: milvus-io/milvus#45178
- Improve Redis NCS connector to use Redis pipelining - Merge unit tests for all NCS kinds - Add concurency test using multiple NcsConnector
- Use std::unique_ptr for Redis resources (redisContext/redisReply) - Add USE_REDIS CMake option to make Redis support optional - Delete copy/move operations for NcsConnector - Initialize all member variables with default values - Reorganize error codes (moved NcsUploadError to 2044) - Remove using clauses from header files
Author
|
@alexanderguzhva thanks for the feedback! I've addressed the comments in the latest commit. Happy to make further adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces the core infrastructure for Near-Compute Storage (NCS), a shared hot storage tier designed to decouple compute and storage in Milvus.
Key changes:
NcsSingleton,NcsFactory, andNcsConnectorinterfaces to abstract storage backends.InMemoryNcsandInMemNcsConnectorbacked byInMemoryKVfor testing.RedisNcsandRedisNcsConnectoras a reference remote storage backend.ncs_c.h) to allow integration with the Milvus Go control plane.This infrastructure enables upper layers (Knowhere, Milvus) to interact with disaggregated storage through a unified Key-Value API.
issue: milvus-io/milvus#45178