refactor: reduce loading overhead tracker lock contention#86
Open
sunby wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces lock contention in
LoadingOverheadTrackerby splitting the previous single global mutex into:std::shared_mutexfor group/handle map accessGroupStatemutex for reservation state updatesThe hot-path operations (
Reserve,Release,HasFiniteUpperBound, andGetUpperBound) now take a shared map lock, copy the target group state pointer, and only serialize updates within that group. This allows independent groups to reserve/release loading overhead without blocking each other on one global tracker mutex.Registration and cleanup behavior is preserved:
Unregisterstill removes the group at ref count 0 and logs residual reservations before cleanupTesting
pre-commitpassedUT on ubuntu-22.04passedUT on macos-15passed