WIP: Add OpContext trace span helpers#96
Open
jamesgao-jpg wants to merge 5 commits into
Open
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
8cfb483 to
5910cf8
Compare
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
5910cf8 to
45bff01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
milvus::OpContext::trace_spanas the trace parent carrier for downstream search pathsmilvus::OpContext::GetTraceSpan()accessors for trace span readscommon/Tracer.hfor Cardinal and Knowherecommon/Trace.hwrapper; callers should includecommon/Tracer.hdirectlyNestedSpanGuardSetTemporaryOpContextTraceSpanandStartScopedSpan; callers now constructNestedSpanGuardandScopedSpandirectlyDependency context
Earlier branch commit
6476f5068efdea819403dff9cb42f8f9f37f502dwas published asmilvus-common/1.0.0-6476f50@milvus/dev#96b754f8757ce3c59471b6d8dcbfaba4.Branch commit
242dedaaa2af86f1c070872cc75cc62e58e1882fwas tagged asv1.0.0-242deda, but it is superseded by current branch commit45bff01293e050be7af2c9c1e5b70c49da8940ef, which moves the helper APIs intocommon/Tracer.hand removescommon/Trace.h. A new tag/package is needed before downstream conan pins can move.Downstream PRs consuming this helper package:
Verification
git diff --checkrg -n "common/Trace\\.h|Trace.h"across milvus-common, Knowhere, and Cardinal: no matchesmake testwas attempted locally but did not run becauseconanis not available on PATH in this local environment.