Skip to content

fix: use lower or upper bound when changing from same value #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use lower or upper bound when changing from same value #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/components/ReactSlider/ReactSlider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,13 +575,21 @@ class ReactSlider extends React.Component {
return prepareOutValue(this.state.value);
}

getClosestIndex(pixelOffset) {
getClosestIndex(pixelOffset, nextValue) {
let minDist = Number.MAX_VALUE;
let closestIndex = -1;

const { value } = this.state;
const l = value.length;

if (new Set(value).size === 1) {
if (value[0] > nextValue) {
return 0;
}

return value.length - 1;
}

for (let i = 0; i < l; i += 1) {
const offset = this.calcOffset(value[i]);
const dist = Math.abs(pixelOffset - offset);
Expand Down Expand Up @@ -771,8 +779,8 @@ class ReactSlider extends React.Component {
// and calls `callback` with that thumb's index.
forceValueFromPosition(position, callback) {
const pixelOffset = this.calcOffsetFromPosition(position);
const closestIndex = this.getClosestIndex(pixelOffset);
const nextValue = trimAlignValue(this.calcValue(pixelOffset), this.props);
const closestIndex = this.getClosestIndex(pixelOffset, nextValue);

// Clone this.state.value since we'll modify it temporarily
// eslint-disable-next-line zillow/react/no-access-state-in-setstate
Expand Down