Skip to content

fix: fix issue with size calculation when slider is hidden #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: fix issue with size calculation when slider is hidden #318

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ca3119
fix: fix issue with size calculation when slider is hidden
jimmymorris Jun 5, 2024
5772ea1
fix: removing metadata updates for newer npm version
jimmymorris Jun 5, 2024
b5c8fb1
fix: removing metadata updates for newer npm version
jimmymorris Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/ReactSlider/ReactSlider.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,11 @@ class ReactSlider extends React.Component {
componentDidUpdate() {
// If an upperBound has not yet been determined (due to the component being hidden
// during the mount event, or during the last resize), then calculate it now
if (this.state.upperBound === 0) {
if (
this.state.upperBound === 0 ||
this.state.thumbSize === 0 ||
this.state.sliderLength === 0
) {
this.resize();
}
}
Expand Down