feat: resolve multiple assigned issues (keyboard nav, PNG download, step labels, rate-limit banner)#181
Merged
Conversation
|
@Smartdevs17 is attempting to deploy a commit to the zintarh Team on Vercel. A member of the Team first needs to authorize it. |
|
@Smartdevs17 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
… PNG download, indexing step progress labels, keyboard navigation Closes zintarh#80 - Rate-limit banner auto-dismisses after indexer recovery - Added useRateLimitStore.reset() calls on successful indexing completion - Added tests for banner visibility conditions Closes zintarh#82 - Download share card as PNG button - Added DownloadPngButton component to ShareImageCard.tsx - Integrated download button in share page floating menu - Uses html2canvas to capture card at 3x resolution - Filename defaults to stellar-wrap-{address-short}.png Closes zintarh#88 - Real-time indexing step progress with labels - Replaced IndexingSkeleton with StepProgressDisplay in loading page - StepProgressDisplay shows current step label, step progress, completed checkmarks - Smooth framer-motion transitions between steps Closes zintarh#90 - Keyboard navigation support - Added visible focus ring styles in globals.css - Added onKeyDown handlers (Enter/Space) to all interactive elements - Added Escape key to close share menus - Added aria attributes (role, aria-label, aria-expanded, aria-checked) - Applied to: period selector, CTA, share buttons, navigation buttons, toggle buttons
Smartdevs17
force-pushed
the
feat/resolve-assigned-issues
branch
from
1440cbf to
794caef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves all four issues assigned to me in a single PR.
Issues Resolved
Changes
#80 - Rate-limit Banner Auto-Dismiss
useRateLimitStore.getState().reset()calls on successful completion inIndexerRecoveryService(runFrom,continueFrom,retryFailedStep)#82 - Download Share Card as PNG
DownloadPngButtoncomponent exported fromShareImageCard.tsxhtml2canvasstellar-wrap-{address-short}.png#88 - Indexing Step Progress Labels
IndexingSkeletonwithStepProgressDisplayin loading pageINDEXING_STEPSconfig#90 - Keyboard Navigation
focus-visible) toglobals.cssonKeyDownhandlers (Enter/Space) to all interactive elementsrole,aria-label,aria-expanded,aria-checked,role="menuitem"