Added add method to allow adding values to cache directly.
#56
Conversation
| * will be returned to all fibers. | ||
| */ | ||
| sealed abstract class Cache[-Key, +Error, +Value] { | ||
| sealed abstract class Cache[-Key, +Error, Value] { |
There was a problem hiding this comment.
The loss of variance is a significant downside here. We should try to push this functionality into the Lookup function.
There was a problem hiding this comment.
I'll rework it... Yeah, I encountered some problem with variance. Tried doing [V >: Value] but the underlying Hashmap/ConcurrentHashmap is invariant. As a compromise, I made Value invariant, hence the draft :)
Let me rework this. Thanks Adam.
There was a problem hiding this comment.
@adamgfraser did you have any additional thoughts on how to push this into Lookup. I've been playing around with it a little without much luck. Tried adding a get function that accepts a custom/temporary lookup, but gets messy because you have to add that to the interface level as well
3 participants
Resolves #39