-
Notifications
You must be signed in to change notification settings - Fork 372
Deal with nil rack.input with rack 3.1 #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can this be merged? Can a new version be released? |
|
+1, can't upgrade rack because of this issue |
1 similar comment
|
+1, can't upgrade rack because of this issue |
|
interesting. Thanks for reporting this. We need to get CI passing too |
|
So you couldn't get CI passing for months? Everybody needs this fix to make it work with rack 3.1.x and this PR was opened 1 year ago... |
|
That is correct. So it goes in open source at times |
|
CI is passing now. This PR is related to #541 |
|
Any chance of this getting merged soon? 🙏 |
|
@rahearn, are you available to take a stab at the merge conflicts? That would be amazing and I would really appreciate it 🎉 |
|
It looks like #528 fixed this issue (via |
|
@rahearn, thank you for your response. I have the newest version of the gem, and the issue you linked, did not fix my error, unfortunately. This PR above changes it to: Maybe I am reading it wrong. I appreciate your time to respond and look into this! 🙏 P.S.: Patching it like this in my codebase does work. |
After moving to rack 3.1.x,
last_request.env["rack.input"]is returning nil ongetrequests. This will safely deal with that situation, replacing the return value with an empty string.