Skip to content

⚡ [Convert columns array to a Set for O(1) lookups in deleteColumns] #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zknpr merged 2 commits into from
Jun 8, 2026
Merged

⚡ [Convert columns array to a Set for O(1) lookups in deleteColumns] #443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c149042
Convert array includes to Set has for O(1) filtering
google-labs-jules[bot] Jun 8, 2026
591be0f
chore: revert stray package-lock version bump
zknpr Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion website/public/sqlite-viewer/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,8 @@ async function deleteColumns(table, columns) {

// Get current table info
const tableInfo = await getTableInfo(table);
const remainingColumns = tableInfo.filter(c => !columns.includes(c.name));
const columnsSet = new Set(columns);
const remainingColumns = tableInfo.filter(c => !columnsSet.has(c.name));

if (remainingColumns.length === 0) {
throw new Error('Cannot delete all columns');
Expand Down
Loading