Skip to content

🧹 [code health improvement] Use proper logging instead of console.warn for fallback saves #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zknpr merged 1 commit into from
Jun 8, 2026
Merged

🧹 [code health improvement] Use proper logging instead of console.warn for fallback saves #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/databaseModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
return;
} catch (e) {
// Fallback if direct write fails
console.warn('Direct write failed, falling back to buffer transfer', e);
this.viewerProvider.outputChannel?.appendLine(`[Fallback] Direct write failed, falling back to buffer transfer: ${e instanceof Error ? e.message : String(e)}`);
}
}

Expand Down Expand Up @@ -425,7 +425,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
await this.databaseOperations.writeToFile(targetUri.fsPath);
return;
} catch (e) {
console.warn('Direct write failed, falling back to buffer transfer', e);
this.viewerProvider.outputChannel?.appendLine(`[Fallback] Direct write failed, falling back to buffer transfer: ${e instanceof Error ? e.message : String(e)}`);
}
}

Expand Down
30 changes: 14 additions & 16 deletions tests/unit/databaseModel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,15 +365,14 @@ describe('DatabaseDocument save/saveAs fallback', () => {
configurable: true
});

const originalConsoleWarn = console.warn;
let consoleWarnCalled = false;
console.warn = (msg: string, err: any) => {
if (msg && msg.includes('Direct write failed')) {
consoleWarnCalled = true;
} else {
originalConsoleWarn(msg, err);
doc.viewerProvider.outputChannel = {
appendLine: (msg: string) => {
if (msg && msg.includes('Direct write failed')) {
consoleWarnCalled = true;
}
}
};
} as any;

try {
await doc.saveAs(targetUri, undefined);
Expand All @@ -388,7 +387,7 @@ describe('DatabaseDocument save/saveAs fallback', () => {
writable: true,
configurable: true
});
console.warn = originalConsoleWarn;

}
});

Expand Down Expand Up @@ -424,15 +423,14 @@ describe('DatabaseDocument save/saveAs fallback', () => {
configurable: true
});

const originalConsoleWarn = console.warn;
let consoleWarnCalled = false;
console.warn = (msg: string, err: any) => {
if (msg && msg.includes('Direct write failed')) {
consoleWarnCalled = true;
} else {
originalConsoleWarn(msg, err);
doc.viewerProvider.outputChannel = {
appendLine: (msg: string) => {
if (msg && msg.includes('Direct write failed')) {
consoleWarnCalled = true;
}
}
};
} as any;

try {
await doc.save();
Expand All @@ -446,7 +444,7 @@ describe('DatabaseDocument save/saveAs fallback', () => {
writable: true,
configurable: true
});
console.warn = originalConsoleWarn;

}
});

Expand Down
Loading