Skip to content

🧹 [code health improvement] Replace console.error with GlobalOutputChannel in databaseModel.ts #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🧹 [code health improvement] Replace console.error with GlobalOutputChannel in databaseModel.ts #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/databaseModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
this.#contentChangeEmitter.fire({});
this.#autoSaveIfNeeded();
} catch (e) {
console.error('[Undo] Failed:', e);
GlobalOutputChannel?.appendLine(`[Undo] Failed: ${e instanceof Error ? e.message : String(e)}`);
vsc.window.showErrorMessage(vsc.l10n.t('Undo failed: {0}', e instanceof Error ? e.message : String(e)));
}
},
Expand All @@ -292,7 +292,7 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
this.#contentChangeEmitter.fire({});
this.#autoSaveIfNeeded();
} catch (e) {
console.error('[Redo] Failed:', e);
GlobalOutputChannel?.appendLine(`[Redo] Failed: ${e instanceof Error ? e.message : String(e)}`);
vsc.window.showErrorMessage(vsc.l10n.t('Redo failed: {0}', e instanceof Error ? e.message : String(e)));
}
}
Expand Down Expand Up @@ -470,7 +470,6 @@ export class DatabaseDocument extends Disposable implements vsc.CustomDocument {
// Record auto-save failures in the output channel for debugging instead of showing a UI error
const errorMessage = err instanceof Error ? err.message : String(err);
GlobalOutputChannel?.appendLine(`[Auto-save failed] ${errorMessage}`);
console.error('[Auto-save failed]', err);
}
}

Expand Down
Loading