chore: remove redundant contracts#141
Merged
Merged
Conversation
saleel
commented
May 5, 2026
saleel
commented
May 5, 2026
| [submodule "src/solidity/lib/zkpassport-packages"] | ||
| path = src/solidity/lib/zkpassport-packages | ||
| url = git@github.com:zkpassport/zkpassport-packages.git | ||
| branch = saleel/sol-sync |
Collaborator
Author
There was a problem hiding this comment.
Need to change this once PR on packages in merged
Contributor
There was a problem hiding this comment.
Same goes for the foundry.lock
saleel
force-pushed
the
saleel/cleanup-contracts
branch
from
eb3c91c to
7e8ea6e
Compare
saleel
commented
May 5, 2026
| "root": "0x26fa1d2e130fb4d3234f56e51662631f80c2be7ef07ad6368376fd59e3e67a8e", | ||
| "circuits": { | ||
| "bind": { | ||
| "hash": "0x2153bca1ada0b33ad7d9079f8cd961a13489225063eb23b00801cf30092bb181", | ||
| "cid": "QmX2LAe2Xi77BzAFi42HeQjCifh8j3Qn6dCEiXaqRsvYE4", | ||
| "cid": "QmNnj294ZNpAK8xhmDqoeTcAUcJXLApepRadXnAZCkv2n6", |
Collaborator
Author
There was a problem hiding this comment.
For some reason this file was not committed earlier
madztheo
approved these changes
May 5, 2026
Contributor
madztheo
left a comment
madztheo
left a comment
There was a problem hiding this comment.
Good to go once the PR on packages is merged, so this can target main rather than the feature branch
Contributor
There was a problem hiding this comment.
I guess we need to merge the PR on packages first, so this can be removed?
| [submodule "src/solidity/lib/zkpassport-packages"] | ||
| path = src/solidity/lib/zkpassport-packages | ||
| url = git@github.com:zkpassport/zkpassport-packages.git | ||
| branch = saleel/sol-sync |
Contributor
There was a problem hiding this comment.
Same goes for the foundry.lock
saleel
force-pushed
the
saleel/cleanup-contracts
branch
from
7c99dbe to
ef5c205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.