Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Deferred to IO to reflect that its an I/O monad. #88

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Rename Deferred to IO to reflect that its an I/O monad. #88

merged 1 commit into from
Dec 25, 2024

Conversation

zoj613
Copy link
Owner

@zoj613 zoj613 commented Dec 25, 2024

Also use destructive substituion where needed to make function signature return types more explicit.

Also use destructive substituion where needed to make function signature
return types more explicit.
@zoj613 zoj613 added storage related to storage refactoring I/O relating to I/O operations and concurrency. labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.60%. Comparing base (00ade96) to head (684ef4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
zarr/src/storage/memory.ml 61.53% 5 Missing ⚠️
zarr/src/storage/zip.ml 54.54% 5 Missing ⚠️
zarr-lwt/src/storage.ml 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   97.60%   97.60%   -0.01%     
==========================================
  Files          13       13              
  Lines        1546     1544       -2     
==========================================
- Hits         1509     1507       -2     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoj613 zoj613 merged commit 5d79457 into main Dec 25, 2024
2 of 4 checks passed
@zoj613 zoj613 deleted the io branch December 25, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I/O relating to I/O operations and concurrency. refactoring storage related to storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant