Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package
app-project
lib-react-components
Linked Issue and/or Talk Post
Ideally we'll be able to close #5859
Describe your changes
It'd be nice to use CSS for styling that's dependent on viewport size (mobile vs desktop) rather than Javascript. This is an experiment removing
react-resize-detector
from the following components in favor of media queries or container queries:I refactored ZooHeader's unit tests to use
composeStory
in combo with the variety of existing Storybook components.How to Review
Both components have robust Storybook components, so it's easiest to run each and try out various screen widths.
I might open a similar PR in the future that uses CSS container queries for FlipbookControls, ImageAndTextControls, and SeparateFramesViewer in the future. Those three use the ResizeObserver API to adjust styling depending on container width.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Refactoring