Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: ADR 62 - Volumetric Point Tool #6194

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DRAFT: ADR 62 - Volumetric Point Tool #6194

wants to merge 1 commit into from

Conversation

kieftrav
Copy link
Contributor

@kieftrav kieftrav commented Aug 6, 2024

Package

lib-classifier

Describe your changes

Distillation of Volumetric Viewer + Volumetric Point Tool conversation at ZTM. No effect on any code in the codebase so minimal review requirements from a deployment perspective.

@kieftrav kieftrav requested review from goplayoutside3 and a team August 6, 2024 13:59
@coveralls
Copy link

Coverage Status

coverage: 79.023% (-0.03%) from 79.056%
when pulling 0d4b4cb on ADR-61
into b1564f7 on master.

Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get #6193 approved first, but jumping over from reviewing that ADR, this ADR is focused on the Tool needed to classify a 3D subject. In the Zooniverse classifier, the tool, annotation, and task are more closely related to the classification object eventually sent to panoptes, and should be discussed in detail here. Yes, a volunteer will be using the tool on top of the 3D viewer, but discussion of the models can be isolated from explanations about UI decisions.

Here are some guiding questions for this ADR to be a helpful reference in the future:

  • Are you creating a new Subject model in the classifier, or using existing data subject models?
  • Are you creating a new Annotation model or do the existing models in the MobX Store work?
  • Does this new tool require a new task type? How does that type fit into the project builder?
  • What parts of the existing drawing tools in FEM's classifier suffice, or are you creating an entirely new tool?

There's a lot to consider about viewer + tool + annotation + classification + task type, but I want to avoid incomplete discussions across multiple ADRs.

@kieftrav kieftrav marked this pull request as draft August 15, 2024 15:10
@kieftrav kieftrav changed the title ADR 61: Volumetric Point Tool DRAFT: ADR 62 - Volumetric Point Tool Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants