Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Image Info for SVG files #1146

Merged
merged 9 commits into from
Sep 16, 2023
Merged

Added Image Info for SVG files #1146

merged 9 commits into from
Sep 16, 2023

Conversation

drfho
Copy link
Contributor

@drfho drfho commented Aug 26, 2023

SVG images are common today: now OFS.Image.getImageInfo can read the image dimensions from the xml file data in pixels (int-normalized).

svg_image_props

drfho added a commit to zopefoundation/Products.CMFCore that referenced this pull request Aug 26, 2023
drfho added a commit to zms-publishing/ZMS that referenced this pull request Aug 26, 2023
src/OFS/Image.py Outdated Show resolved Hide resolved
Co-authored-by: Leonardo Rochael Almeida <[email protected]>
Copy link
Contributor Author

@drfho drfho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Thanks.

@drfho drfho enabled auto-merge (squash) September 16, 2023 16:18
@drfho drfho disabled auto-merge September 16, 2023 16:19
@drfho drfho merged commit a9b1e5b into master Sep 16, 2023
23 checks passed
@drfho drfho deleted the ofs_handle_svg_images branch September 16, 2023 16:34
@@ -49,6 +49,8 @@ https://github.com/zopefoundation/Zope/blob/4.x/CHANGES.rst
- Update ``AccessControl`` to version 6.2 to mitigate a security problem.
(CVE-2023-41050)

- Added image dimensions to SVG file properties
`#1146 <https://github.com/zopefoundation/Zope/pull/1146>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog is now in the paragraph for 5.8.4 (2023-09-06) which was already released. I made #1158 to move it to the latest "unreleased" paragraph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants