Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6 legacy status #126

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Remove Python 3.6 legacy status #126

merged 1 commit into from
Nov 3, 2021

Conversation

dataflake
Copy link
Member

This change removes the part of cf84a7f that moved Python 3.6 to legacy status.

Please see the discussion at zopefoundation/Zope#988 (comment) for why I think it is a bad idea to be aggressive about retiring Python versions.

There's a more general issue here about how this package distinguishes Python versions. I think the distinctions are becoming more of an obstacle for real-life packages which lose Python version support for no good reason, just because a decision was made in this particular package.

Instead of generally thinking about which Python versions are at or near EOL (as this package does) we should think in terms of what our main packages like Zope or ZODB are still supporting. Those must keep good backwards compatibility in a given release series and can't just arbitrarily drop Python version support.

@dataflake dataflake added the enhancement New feature or request label Oct 31, 2021
@dataflake dataflake requested a review from icemac October 31, 2021 09:48
@dataflake dataflake self-assigned this Oct 31, 2021
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I am glad we finally settled on a compromise.

@icemac icemac merged commit 844142f into master Nov 3, 2021
@icemac icemac deleted the dataflake/retain_py36 branch November 3, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants