Issue #905: Switch codebase to Monorepo #981

phaumer · 2020-08-15T00:06:48Z

Proposed changes

Details and discussion in #905

Release Notes

Converted source code to monorepo using yarn and extracted extender's API to importable npm package.

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Peter Haumer <[email protected]>

…r-zowe into monorepo-switch Signed-off-by: Peter Haumer <[email protected]>

Signed-off-by: Peter Haumer <[email protected]>

zdmullen · 2020-08-18T14:59:19Z

To be demoed Tuesday, August 25.

We will follow up with a discussion of the merge order. One idea is to merge this into a release (like 1.9.0) and immediately create a "fix" branch, for example 1.9.x, where we put the subsequent PRs.

Signed-off-by: Billie Simmons <[email protected]>

Signed-off-by: Peter Haumer <[email protected]>

VitGottwald · 2020-08-26T19:06:11Z

Due to several of commits that were left unsigned, I had to squash the this branch into a single commit and force push it. My apologies @phaumer, @JillieBeanSim, and others.

The commit before the squash was aa6615f as the PR history shows. The current commit is 17c0233. Anyone can verify that the contents of the files has not changed by running git diff aa6615f 17c0233.

phaumer · 2020-09-01T04:50:57Z

@VitGottwald I don't think a force push into someone else's branch is a good practice. If you are signing with a gmail address what is the point anyway? You could have added something to the dco_signoffs folder.

VitGottwald · 2020-09-03T14:34:26Z

Hi Peter, sorry for that. What is dco_signoffs folder?

VitGottwald · 2020-09-10T09:04:58Z

After a discussion with Peter, I restored the branch (see the force push above). And I am going to add a record to the dco_signoffs folder.

Signed-off-by: Peter Haumer <[email protected]>

packages/zowe-explorer-api/package.json

jellypuno · 2020-10-22T12:57:49Z

Here are some of the issues that I've found:

Profile used: z/OSMF Profile with SCS

This error message appeared during initialization:

Names for Allocate Like and Validation is not found:

Signed-off-by: zFernand0 <[email protected]>

zFernand0 · 2020-10-22T13:38:44Z

9679017 should resolve missing messages/descriptions #981 (comment)

5af5bed is mostly to make GH happy as nothing really changed.
Huge thanks to @phaumer for resolving all merge conflicts ahead of time!

…-zowe into monorepo-switch Signed-off-by: zFernand0 <[email protected]> # Conflicts: # README.md # __mocks__/mockCreators/api.ts # __mocks__/mockCreators/jobs.ts # __mocks__/mockCreators/uss.ts # __tests__/__integration__/uss/ussNodeActions.integration.test.ts # __tests__/__unit__/abstract/TreeProvider.unit.test.ts # __tests__/__unit__/dataset/DatasetTree.unit.test.ts # __tests__/__unit__/uss/USSTree.unit.test.ts # __tests__/__unit__/uss/ZoweUSSNode.unit.test.ts # i18n/sample/package.i18n.json # i18n/sample/src/Profiles.i18n.json # i18n/sample/src/dataset/DatasetTree.i18n.json # i18n/sample/src/dataset/actions.i18n.json # i18n/sample/src/job/ZosJobsProvider.i18n.json # i18n/sample/src/uss/USSTree.i18n.json # package-lock.json # package.json # package.nls.json # packages/zowe-explorer-api/src/Profiles.ts # packages/zowe-explorer-api/src/ZoweExplorerZosmfApi.ts # packages/zowe-explorer/__mocks__/mockCreators/datasets.ts # packages/zowe-explorer/__tests__/__integration__/DatasetTree.integration.test.ts # packages/zowe-explorer/__tests__/__integration__/USSTree.integration.test.ts # packages/zowe-explorer/__tests__/__integration__/extension.integration.test.ts # packages/zowe-explorer/__tests__/__unit__/Profiles.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/dataset/actions.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/extension.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/job/ZosJobsProvider.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/job/ZoweJobNode.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/job/actions.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/shared/actions.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/shared/utils.unit.test.ts # packages/zowe-explorer/__tests__/__unit__/uss/actions.unit.test.ts # packages/zowe-explorer/src/abstract/ZoweTreeProvider.ts # packages/zowe-explorer/src/command/MvsCommandHandler.ts # packages/zowe-explorer/src/dataset/ZoweDatasetNode.ts # packages/zowe-explorer/src/dataset/actions.ts # packages/zowe-explorer/src/extension.ts # packages/zowe-explorer/src/globals.ts # packages/zowe-explorer/src/job/ZosJobsProvider.ts # packages/zowe-explorer/src/job/ZoweJobNode.ts # packages/zowe-explorer/src/job/actions.ts # packages/zowe-explorer/src/shared/actions.ts # packages/zowe-explorer/src/uss/ZoweUSSNode.ts # packages/zowe-explorer/src/uss/actions.ts # src/dataset/DatasetTree.ts # src/dataset/dsNodeActions.ts # src/dataset/utils.ts # src/uss/USSTree.ts

Signed-off-by: Peter Haumer <[email protected]>

Remove it from workflow. Trigger workflow only on changes to the zowe-explorer package Signed-off-by: zFernand0 <[email protected]>

Signed-off-by: zFernand0 <[email protected]>

Signed-off-by: Peter Haumer <[email protected]>

Signed-off-by: zFernand0 <[email protected]>

Signed-off-by: Peter Haumer <[email protected]>

…r-zowe into monorepo-switch

Signed-off-by: Lauren Li <[email protected]>

…-zowe into monorepo-switch Signed-off-by: zFernand0 <[email protected]> # Conflicts: # package-lock.json # package.json

zFernand0

LGTM!

zFernand0 · 2020-11-04T14:18:54Z

Unit tests are passing, but the workflow fails to save the results.
We can address this in a subsequent PR 😋

…repo-switch

* Created packages. Fixed building. Signed-off-by: Peter Haumer <[email protected]> * VSIX patch script. Fixed launches. Signed-off-by: Peter Haumer <[email protected]> * Added vscode-nls to webpack Signed-off-by: Peter Haumer <[email protected]> * Simplified webpack config * Move eslint plugin devDependency * Switch github actions to yarn * Switch theia github action to yarn * Use yarn for installs and script running * Extracted explorer-api and refactored Signed-off-by: Peter Haumer <[email protected]> * Added prettier Signed-off-by: Peter Haumer <[email protected]> * Renamed pub folder to dist Signed-off-by: Peter Haumer <[email protected]> * add/update scripts for pre/posttest:integration Signed-off-by: Billie Simmons <[email protected]> * Added ftp package files Signed-off-by: Peter Haumer <[email protected]> * Enabling webpack for FTP Signed-off-by: Peter Haumer <[email protected]> * Fixed eslint for ftp Signed-off-by: Peter Haumer <[email protected]> * Added FTP launch Signed-off-by: Peter Haumer <[email protected]> * Add DCO signoff for past commits * Pretty 120 zowe explorer Signed-off-by: Peter Haumer <[email protected]> * Pretty 120 api Signed-off-by: Peter Haumer <[email protected]> * Pretty 120 ftp Signed-off-by: Peter Haumer <[email protected]> * Prettier top level Signed-off-by: Peter Haumer <[email protected]> * Merging 1.10 master branch Signed-off-by: Peter Haumer <[email protected]> * Prettier 120/4 Signed-off-by: Peter Haumer <[email protected]> * Removed test profile Signed-off-by: Peter Haumer <[email protected]> * Updated gitignore Signed-off-by: Peter Haumer <[email protected]> * Add missing messages Signed-off-by: zFernand0 <[email protected]> * yarn package fixes Signed-off-by: Peter Haumer <[email protected]> * Move testProfileData.ts file creation to a script in zowe-explorer. Remove it from workflow. Trigger workflow only on changes to the zowe-explorer package Signed-off-by: zFernand0 <[email protected]> * Quick fix for uploading test results Signed-off-by: zFernand0 <[email protected]> * yarn and vsce devDeps Signed-off-by: Peter Haumer <[email protected]> * Profiles split Signed-off-by: Peter Haumer <[email protected]> * add yarnrc file Signed-off-by: zFernand0 <[email protected]> * Fixed imports Signed-off-by: Peter Haumer <[email protected]> * String updates Signed-off-by: Peter Haumer <[email protected]> * Moved another UI method Signed-off-by: Peter Haumer <[email protected]> * Update filepaths for monorepo Signed-off-by: Lauren Li <[email protected]> Co-authored-by: Vit Gottwald <[email protected]> Co-authored-by: Billie Simmons <[email protected]> Co-authored-by: zFernand0 <[email protected]> Co-authored-by: Lauren Li <[email protected]> Signed-off-by: zFernand0 <[email protected]>

phaumer and others added 14 commits August 10, 2020 17:53

Created packages. Fixed building.

46ceb85

Signed-off-by: Peter Haumer <[email protected]>

VSIX patch script. Fixed launches.

cf45ab9

Signed-off-by: Peter Haumer <[email protected]>

Added vscode-nls to webpack

e018fa1

Signed-off-by: Peter Haumer <[email protected]>

Simplified webpack config

592ea55

Move eslint plugin devDependency

e766680

Switch github actions to yarn

5a96b0f

Switch theia github action to yarn

0b6f836

Use yarn for installs and script running

9659bf9

Extracted explorer-api and refactored

d6978b8

Signed-off-by: Peter Haumer <[email protected]>

Merge branch 'monorepo-switch' of github.com:zowe/vscode-extension-fo…

3147f06

…r-zowe into monorepo-switch Signed-off-by: Peter Haumer <[email protected]>

Added prettier

b0bfad5

Signed-off-by: Peter Haumer <[email protected]>

Renamed pub folder to dist

8115b7d

Signed-off-by: Peter Haumer <[email protected]>

Merge PR 962 from master

4843b08

Signed-off-by: Peter Haumer <[email protected]>

Merge master with PR 980

fd4f42e

Signed-off-by: Peter Haumer <[email protected]>

phaumer changed the title ~~Switch codebase to Monorepo~~ Issue #905: Switch codebase to Monorepo Aug 18, 2020

JillieBeanSim and others added 5 commits August 19, 2020 16:27

add/update scripts for pre/posttest:integration

41dd8e9

Signed-off-by: Billie Simmons <[email protected]>

Added ftp package files

e83d468

Signed-off-by: Peter Haumer <[email protected]>

Enabling webpack for FTP

6dc1cfa

Signed-off-by: Peter Haumer <[email protected]>

Fixed eslint for ftp

961a788

Signed-off-by: Peter Haumer <[email protected]>

Added FTP launch

aa6615f

Signed-off-by: Peter Haumer <[email protected]>

VitGottwald force-pushed the monorepo-switch branch 2 times, most recently from c76098f to 17c0233 Compare August 26, 2020 18:59

VitGottwald force-pushed the monorepo-switch branch from 17c0233 to aa6615f Compare September 10, 2020 09:03

VitGottwald and others added 2 commits September 10, 2020 11:08

Add DCO signoff for past commits

fff8a19

Pretty 120 zowe explorer

06b1db9

Signed-off-by: Peter Haumer <[email protected]>

dkelosky reviewed Oct 22, 2020

View reviewed changes

packages/zowe-explorer-api/package.json Show resolved Hide resolved

zFernand0 modified the milestone: 1.10 Release Oct 22, 2020

Add missing messages

9679017

Signed-off-by: zFernand0 <[email protected]>

zFernand0 and others added 13 commits October 22, 2020 11:47

yarn package fixes

0802a01

Signed-off-by: Peter Haumer <[email protected]>

Move testProfileData.ts file creation to a script in zowe-explorer.

d0bed53

Remove it from workflow. Trigger workflow only on changes to the zowe-explorer package Signed-off-by: zFernand0 <[email protected]>

Quick fix for uploading test results

d8b261e

Signed-off-by: zFernand0 <[email protected]>

yarn and vsce devDeps

bca82d7

Signed-off-by: Peter Haumer <[email protected]>

Profiles split

c6c245b

Signed-off-by: Peter Haumer <[email protected]>

add yarnrc file

e86a0c2

Signed-off-by: zFernand0 <[email protected]>

Fixed imports

f7dc4cb

Signed-off-by: Peter Haumer <[email protected]>

String updates

74efe52

Signed-off-by: Peter Haumer <[email protected]>

Moved another UI method

a5c2d92

Signed-off-by: Peter Haumer <[email protected]>

Merge branch 'monorepo-switch' of github.com:zowe/vscode-extension-fo…

e2e3557

…r-zowe into monorepo-switch

Update filepaths for monorepo

023ca35

Signed-off-by: Lauren Li <[email protected]>

Merge branch 'master' of https://github.com/zowe/vscode-extension-for…

22063c3

…-zowe into monorepo-switch Signed-off-by: zFernand0 <[email protected]> # Conflicts: # package-lock.json # package.json

zFernand0 previously approved these changes Nov 4, 2020

View reviewed changes

zFernand0 marked this pull request as ready for review November 4, 2020 14:19

Merge remote-tracking branch 'origin/monorepo-switch-paths' into mono…

6c9264e

…repo-switch

phaumer dismissed zFernand0’s stale review via 6c9264e November 4, 2020 16:52

phaumer self-assigned this Nov 4, 2020

zFernand0 approved these changes Nov 4, 2020

View reviewed changes

zFernand0 merged commit ad0c762 into master Nov 4, 2020

zFernand0 deleted the monorepo-switch branch November 4, 2020 18:54

phaumer mentioned this pull request Nov 21, 2020

Issue #671: More API refactoring and cleanup #1082

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #905: Switch codebase to Monorepo #981

Issue #905: Switch codebase to Monorepo #981

phaumer commented Aug 15, 2020

zdmullen commented Aug 18, 2020 •

edited

Loading

VitGottwald commented Aug 26, 2020

phaumer commented Sep 1, 2020

VitGottwald commented Sep 3, 2020

VitGottwald commented Sep 10, 2020

jellypuno commented Oct 22, 2020 •

edited

Loading

zFernand0 commented Oct 22, 2020 •

edited

Loading

zFernand0 left a comment

zFernand0 commented Nov 4, 2020

Issue #905: Switch codebase to Monorepo #981

Issue #905: Switch codebase to Monorepo #981

Conversation

phaumer commented Aug 15, 2020

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

zdmullen commented Aug 18, 2020 • edited Loading

VitGottwald commented Aug 26, 2020

phaumer commented Sep 1, 2020

VitGottwald commented Sep 3, 2020

VitGottwald commented Sep 10, 2020

jellypuno commented Oct 22, 2020 • edited Loading

zFernand0 commented Oct 22, 2020 • edited Loading

zFernand0 left a comment

Choose a reason for hiding this comment

zFernand0 commented Nov 4, 2020

zdmullen commented Aug 18, 2020 •

edited

Loading

jellypuno commented Oct 22, 2020 •

edited

Loading

zFernand0 commented Oct 22, 2020 •

edited

Loading