Skip to content

Conversation

@shubham-padia
Copy link
Member

@shubham-padia shubham-padia commented Jun 19, 2025

Fixes #1077.
Users were getting stuck in the settings page, unable to click on an organisation tab to go back. Enabling the sidebar for settings page in all cases will help ensure that the users can navigate back when needed.

Screenshots and screen captures:

show sidebar

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (specify distro)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@shubham-padia shubham-padia force-pushed the show-sidebar-in-settings branch from 75e2279 to d15c50e Compare June 20, 2025 08:03
@timabbott
Copy link
Member

I think this should not be hard to finish, but we do need to resolve my correctness concerns above before it's ready for Anders to review.

Fixes zulip#1077.
Users were getting stuck in the settings page, unable to click on an
organisation tab to go back. Enabling the sidebar for settings page in
all cases will help ensure that the users can navigate back when
needed.
@shubham-padia shubham-padia force-pushed the show-sidebar-in-settings branch from d15c50e to 6466e5f Compare November 26, 2025 07:52
@timabbott timabbott requested a review from andersk November 26, 2025 18:48
@timabbott
Copy link
Member

This version looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stuck in preferences

3 participants