inbox: Fix bug where channel unread badge text color was slightly wrong #1895
+93
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM and tests great. Over to Greg's review.
rajveermalviya
added
integration review
gnprice
reviewed
Oct 7, 2025
There was a problem hiding this comment.
Thanks @chrisbobbe for the fix, and thanks @rajveermalviya for testing it! Two nits below; otherwise all looks good.
lib/widgets/unread_count_badge.dart
Outdated
| super.key, | ||
| required this.count, | ||
| required this.backgroundColor, | ||
| this.channelIdForBackground, |
There was a problem hiding this comment.
Perhaps keep this required? I think "use the not-in-a-channel coloring" isn't necessarily a good default, even though it's represented by null.
Comment on lines
56
to
60
| await prepare(tester, | ||
| child: UnreadCountBadge( | ||
| count: 1, | ||
| channelIdForBackground: subscription.streamId), | ||
| subscription: subscription); |
There was a problem hiding this comment.
nit: subscription before child; logically it comes first (it gets applied first), plus the child is a longer argument in the source code
UnreadCountBadge has a needlessly loose API for specifying a background color, with three options: 1. Channel-colorized: callers are supposed to pass a ChannelColorSwatch and the implementation picks `unreadCountBadgeBackground` off of that. 2. Any other Color. (ChannelColorSwatch is a Color.) 3. A default color, chosen by the implementation, if `null` is passed. We don't actually have any use for option 2, at least currently, so we'll remove it next. The buggy caller here was using option 2 when it should have used option 1: it wanted a channel-colored background, but it itself picked `unreadCountBadgeBackground` off of the swatch instead of passing the whole swatch to UnreadCountBadge for it to do that. That would have been fine except that the channel-colorized case has its own associated *text* color, and that's conditioned on whether the passed background color is a ChannelColorSwatch.
Previously, this widget had three options for the background color: 1. Colorized for a channel: callers could pass a ChannelColorSwatch, and the implementation would pick `unreadCountBadgeBackground` off of that. 2. Any `Color`. 3. A default, chosen by the implementation. One caller was using option 2 when option 1 would be a better fit: it wanted a channel-colored background, but it was picking `unreadCountBadgeBackground` itself from the ChannelColorSwatch instead of letting the implementation do that. After changing that caller to just pass the ChannelColorSwatch (option 1), no more callers use option 2, so we remove it. Now UnreadCountBadge has a tighter interface. Next we'll encapsulate finding the channel color swatch itself, so callers only need to have a channel ID if they want a channel-colored background.
chrisbobbe
force-pushed
the
pr-inbox-channel-unread-badge-text-color
branch
from
9edefdb to
ce945d0
Compare
|
Thanks for the review! Revision pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @alya