content: Use directional layout for block quotations #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `Quotation` widget hardcoded the border and padding to the left side. This resulted in an incorrect layout in RTL locales, where the quote bar remained on the left while the text aligned to the right. We now use `EdgeInsetsDirectional` and `BorderDirectional` so that the layout flips correctly based on the text direction.
yash-agarwa-l
force-pushed
the
fix-rtl-quotation
branch
from
4fcdb6e to
771474c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the layout of block quotes (
> quote) in RTL languages.Previously, the vertical bar was stuck on the Left side even in RTL mode. Now, it correctly flips to the Right side (the "start" of the text).
This addresses one of the RTL issues identified by @gnprice in this comment.
Before
LTR
RTL
After
LTR
RTL