content: Use directional layout for message media #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-agarwa-l
force-pushed
the
fix-rtl-messagemedia
branch
from
c574e46 to
eef24bf
Compare
Member
|
Thanks! Quick format comment: please avoid @-mentions in commit messages. See this section of our Git style guide: The description there is actually a bit forward-looking — GitHub's current behavior, and until next month, is that @-mentions do actually cause notifications. That ends up being spammy, because each time the commit gets rebased (and the rebased version pushed to GitHub), that's a new commit and causes a new notification in the person's inbox. |
Previously, these previews (for images and video) were hardcoded to align to the left, with padding on the right. This resulted in an incorrect layout in RTL locales. We now use directional positioning so that the alignment and padding flip correctly based on the text direction.
yash-agarwa-l
force-pushed
the
fix-rtl-messagemedia
branch
from
eef24bf to
3b1880e
Compare
Contributor
Author
|
Thanks for the clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the layout of images and video thumbnails in the message list for RTL languages.
Previously, these media containers were hardcoded to align to the Left side with padding on the Right, even in RTL mode. Now, they correctly flip to the Right side (the "start" of the message) with padding on the correct side.
This addresses the second RTL issue identified by @gnprice in this comment.
Before
LTR
RTL
After
LTR
RTL
Since the Difference is very minute, this might help.