action_sheet: Use directional border radius for reaction buttons #2010
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the reaction buttons in the message action sheet used hardcoded physical border radii. In RTL locales, this caused the rounded corners to appear on the inner edges of the button row instead of the outer edges. We now use and resolve it against the context's text direction to ensure the correct corners are rounded regardless of layout direction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the border radius of the reaction buttons in the message action sheet for RTL languages.
Previously, the "First" button (e.g., thumbs up) and the "More" button (...) had hardcoded rounded corners. In RTL mode, these corners remained on the physical side, which resulted in the inner corners being rounded instead of the outer ones.
We now use
BorderRadiusDirectionalresolved against the text direction to ensure the outer edges are always the ones rounded.This addresses the third RTL issue identified by @gnprice in this comment.
Before
(Thumbs Up)
(More ...)
After
(Thumbs Up)
(More ...)