github

[ChitkulLakshya]

• completed 5 tasks
• fixed the github

Description

Type of Change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that changes existing functionality)
• Documentation update
• Refactor (no functional changes)
• CI/CD changes

Related Issues

Screenshots (if applicable)

Testing

• Tested on Windows
• Tested on macOS
• Tested on Linux
• Unit tests added/updated
• Manual testing completed

Checklist

• Code follows project coding standards
• Self-review of code performed
• Comments added for complex logic
• Documentation updated (if applicable)
• All tests pass locally
• No new warnings or errors introduced

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
zync	Ready	Preview, Comment	Apr 3, 2026 10:10am

[Copilot]

Pull request overview

This PR focuses on hardening GitHub-related functionality (notably adding ETag-based caching and switching README retrieval to GitHub App installation tokens), along with a few frontend robustness/type fixes and dependency cleanup.

Changes:

• Update backend GitHub routes to use ETag-aware requests and fetch README content via GitHub App installation access tokens.
• Add defensive array-normalization in note presence and notes layout code paths to avoid crashes when inputs aren’t arrays.
• Remove the unused @reduxjs/toolkit dependency and mark a performance audit task as completed.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/hooks/useNotePresence.ts	Adds normalization guards around presence payloads and active user state.
src/components/views/ActivityLogView.tsx	Adds explicit parameter typing for Chart.js callbacks to satisfy TS.
src/components/notes/NotesLayout.tsx	Adds safety checks around folders/notes to prevent non-array runtime errors.
package.json	Removes @reduxjs/toolkit dependency.
package-lock.json	Updates lockfile to reflect dependency removal.
MD/PERFORMANCE_AUDIT.md	Marks the GitHub ETags audit item as completed.
backend/routes/github.js	Adds ETag usage for GitHub API calls and switches README fetching to installation tokens.

Comments suppressed due to low confidence (1)

src/components/views/ActivityLogView.tsx:415

• Typing the Chart.js tooltip callback parameter as any fixes the TS error but removes type safety. Prefer using Chart.js provided types (e.g., TooltipItem<'doughnut'>) or unknown + narrowing so future refactors don’t silently break tooltip rendering.

                            label: (ctx: any) => {
                                const v = Number(ctx.raw) || 0;
                                const m = Math.round(v / 60);
                                return `${ctx.label}: ${m} min`;
                            },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

getInstallationAccessToken() ultimately reads the GitHub App private key from process.env.GITHUB_APP_PRIVATE_KEY, but the repo’s env template/documentation uses GITHUB_PRIVATE_KEY. As-is, this route can crash at runtime when generating the JWT. Align the env var name (or add fallback) and update .env.example accordingly.

Suggested change

	const githubAppPrivateKey =
	process.env.GITHUB_APP_PRIVATE_KEY || process.env.GITHUB_PRIVATE_KEY;
	if (!githubAppPrivateKey) {
	console.error('GitHub App private key is not configured. Set GITHUB_APP_PRIVATE_KEY or GITHUB_PRIVATE_KEY.');
	return res.status(500).json({ message: 'GitHub App is not configured' });
	}

[Copilot]

The Y-axis tick callback is typed as any. Chart.js exposes a typed signature for tick callbacks (value is typically string | number). Using the proper type (or unknown with narrowing) will preserve type safety and avoid masking integration issues.

Suggested change

	callback: (v: any) => `${v}m`,
	callback: (v: string | number) => `${v}m`,

[Copilot]

If the presence_update payload is sometimes an object (as the new normalization suggests), the earlier users.map(...) debug log will still throw before this usersArray conversion runs. Normalize to usersArray first and use usersArray for any .map()/.filter()/logging.

[Copilot]

owner/repo are interpolated directly into the GitHub URL. Validate they are strings and URL-encode them (e.g., encodeURIComponent) to avoid malformed requests and to prevent cache-key confusion with reserved characters like /, ?, or spaces.

[Copilot]

githubCache is an unbounded in-memory Map, and this route introduces cache entries keyed by (uid, owner, repo, installationId), which can grow without bound on a long-running server. Consider adding TTL and/or a max-size (LRU) eviction strategy.

[Copilot]

After removing @reduxjs/toolkit, it appears Redux-related deps are no longer used (no imports found in src/). If react-redux / redux-persist are truly unused, consider removing them as well to reduce install/bundle size and avoid relying on auto-installed peer deps like redux.