Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce valid check into iterator #110

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

zz-jason
Copy link
Owner

What's changed and how does it work?

Ref to: #97

  • add Valid() to the iterator interface

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 69.51220% with 50 lines in your changes missing coverage. Please review.

Project coverage is 61.71%. Comparing base (2cc6019) to head (71e31c7).

Files Patch % Lines
...clude/leanstore/btree/core/PessimisticIterator.hpp 74.54% 12 Missing and 2 partials ⚠️
src/btree/TransactionKV.cpp 48.14% 9 Missing and 5 partials ⚠️
src/btree/BasicKV.cpp 0.00% 9 Missing and 1 partial ⚠️
src/leanstore-c.cpp 57.14% 6 Missing ⚠️
src/concurrency/HistoryStorage.cpp 25.00% 0 Missing and 3 partials ⚠️
...nstore/btree/core/PessimisticExclusiveIterator.hpp 33.33% 2 Missing ⚠️
tests/btree/BasicKvIteratorTest.cpp 98.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   59.89%   61.71%   +1.81%     
==========================================
  Files         118      119       +1     
  Lines        8756     8817      +61     
  Branches     3294     3469     +175     
==========================================
+ Hits         5244     5441     +197     
+ Misses       3129     3004     -125     
+ Partials      383      372      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zz-jason zz-jason merged commit 495265f into main Aug 13, 2024
5 checks passed
@zz-jason zz-jason deleted the jian.z/iterator-valid branch August 13, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant