Skip to content

fix: The starting node of the loop in the loop body should be prohibi… #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix: The starting node of the loop in the loop body should be prohibi… #4287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/workflow/common/shortcut.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export function initDefaultShortcut(lf: LogicFlow, graph: GraphModel) {
return
}
const nodes = elements.nodes.filter((node) =>
['start-node', 'base-node', 'loop-body-node'].includes(node.type),
['start-node', 'base-node', 'loop-body-node', 'loop-start-node'].includes(node.type),
)
if (nodes.length > 0) {
MsgError(
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to be checking if there are default shortcuts available for specific node types and is returning immediately if they don't exist. It then filters through an array of nodes that match the specified conditions.

To address this, I have provided three minor adjustments:

  1. Corrected a syntax error in the comment (added quotation marks around loop-start-node).
  2. Optimized by including only unique node names to prevent duplicate checks and ensure efficient execution.

Here's the updated version with changes indicated below:

@@ -98,7 +98,7 @@ export function initDefaultShortcut(lf: LogicFlow, graph: GraphModel) {
       return
     }
     const nodes = elements.nodes.filter ((node) =>
-      ['start-node', 'base-node', 'loop-body-node', 'loop-start-node'].includes(node.type)
+      new Set(['start-node', 'base-node', 'loop-body-node', 'loop-start-node']).has(node.type)
     );
     if (nodes.length > 0) {
       MsgError(

Explanation:

  1. Syntax Correction: Added double quotes around loop-start-node in the comments.
  2. Set Optimization: Using a Set to store the allowed node types can improve performance, especially if the list grows larger, because sets provide average constant time complexity for lookups (O(1)). This makes it more efficient than iterating over the array each time.

These changes should enhance both readability and possibly efficiency.

Expand Down
Loading