Repository navigation
docs: add hosted walkthrough and credited v0.2.0 changelog - #6
Conversation
3dhlab
left a comment
There was a problem hiding this comment.
Reviewed head 9eb9371d7efde47acf17330fb78498500a56f7b2 against protected main 71bfb23c5dc6cfb4c7b724ae7829c56fff928600. The diff contains documentation, the edited walkthrough and its previews, with no application, dependency, migration or CI change. The recording is a useful separate Unlock Digital contribution; the following corrections are required before approval.
- State the hosted media permission explicitly. The maintainer has confirmed permission to show the participants in this edited video, with no reuse license for the walkthrough/previews or depicted research content. Identify
docs/media/hosted-walkthrough.mp4,docs/media/hosted-walkthrough.jpganddocs/media/hosted-walkthrough-preview.gifas exceptions to the software's Apache 2.0 scope inLICENSE_STATUS.md,NOTICEand the media documentation. Link those terms beside the README video. Preserve source captions/credits and keep underlying datasets, source interview files and source models outside the repository. The edited public video and previews remain viewable/downloadable; please avoid any claim that their visible or audible content is technically inaccessible. - Keep contribution credit clear. Credit Unlock Digital for this recording/editing beside the README link and in the media guide, alongside the separately credited 3D Humanities Lab demo code/tutorial. Draft #8 proposes five documentation edits for your assessment and incorporation into this fork PR. It targets a review copy of this head, not main, and should be closed as superseded after the wording is incorporated. Please assess/adapt the wording rather than opening a duplicate hosted-video PR.
- Resolve the inherited required dependency gate on an updated base. PR CI 37260559880 passes API, browser and clean-demo jobs; the web production/full audits fail on the existing brace-expansion pin. This is not introduced by the media contribution. The dependency corrections in the independently assessable Lab draft #7 pass all four checks. After the reviewed dependency correction reaches main, update this PR against it and obtain all four passing checks plus a fresh owner review on the final head. Re-running this unchanged head or relaxing the audit would not resolve the dependency failure.
The still-poster README approach in #8 is also recommended so readers choose when motion/audio starts; the optional GIF can remain available. Keep the original Unlock Digital commits and the credited Lab wording contribution in the history. No merge, tag or release is part of this review.
(cherry picked from commit 3be4817)
Assess and adapt the Lab wording from 3dhlab#8: enumerate all three reserved media assets in NOTICE and provenance, link the scope notices at the README video, and describe reuse as rights granted by this presentation. Preserve source credits and the original edited media.
3dhlab
left a comment
There was a problem hiding this comment.
Reviewed revised head d0a4d2cadfaee526237146c3c993a1b36ca745dc against the original inspected 9eb9371.
The permission and credit corrections are addressed: all three hosted assets are enumerated as Apache exceptions, the edited presentation grants no reuse license for the assets or depicted research, original source datasets/interviews/models remain excluded, and Unlock Digital receives visible recording/editing credit. The README uses the still poster. The MP4/JPEG/GIF bytes and hashes are unchanged. The incorporated Lab commit 5821b93 has the exact same tree as draft #8's 3be4817, preserving Lab authorship, followed by your assessed notice refinements. The five documentation edits contain no application/dependency/workflow change. Draft #8 is superseded; thread resolution and proposal closure await the owner's cleanup confirmation.
The required dependency-base correction remains open. Current CI 37313059020 has the reported inherited brace-expansion audit failure; obtain all four passing checks and a fresh owner review after the reviewed dependency correction reaches main and this PR is updated. This comment is not a merge approval.
The current Lab reference in #7 is now de6014175ef47a3257b24084c010500a6ba73f7c, adding version/setup/security documentation to the previously tested code head. Any independent assessment/fork submission should include that small final diff and retain the Lab authorship. No main merge, tag or release has been performed.
3dhlab
left a comment
There was a problem hiding this comment.
Fresh review of #6 head d0a4d2cadfaee526237146c3c993a1b36ca745dc: the media/permission/credit corrections pass assessment. The exact Lab proposal is incorporated with its original authorship, and all three hosted assets remain byte-identical to the earlier inspected presentation. The MP4/JPEG/GIF exceptions, no-reuse terms, visible Unlock Digital recording/editing credit and exclusion of source datasets/models/interviews are consistent. The edited presentation itself remains publicly viewable/downloadable. No further media or notice correction is requested at this head.
The requested corrected-baseline assessment also passes: all four CI jobs succeed on isolated combined commit e97c3db18209cb33a2168aca8fe08665ac5d2ff5, using corrected Lab 699b41f3855ceccf366273da686b4909cb2c04e9 plus this #6 head. Its application/scripts/CI match that tested Lab head, without merge conflicts or changed media. The artifacts verify the dependency audits, full API/privacy/migration suite, browser regression and real generated authoring journey. This is evidence for the combination; it does not change #6's own source head/base or its failed check.
Remaining requested change before approval: after the independently adopted Lab/dependency correction is accepted through protected main, update this fork branch against that actual corrected main, retain the focused media/documentation scope and both contributions' authorship, and obtain all four required checks on the resulting exact head. Then request a fresh owner review. The current PR still uses released main 71bfb23c5dc6cfb4c7b724ae7829c56fff928600; its own run 37313059020 still fails inherited web dependency audits. I cannot give merge approval to that current failing candidate or use the isolated branch check as its check.
The permission proposal #8 is incorporated and should be closed as superseded without a main merge under the owner's cleanup decision. Accept the two contributions separately, then verify final main before a separately authorized tag/Release. This changes-requested review keeps the actual base/CI prerequisite visible; the permissions content finding is addressed.
3dhlab
left a comment
There was a problem hiding this comment.
The independently assessed Lab contribution has now been accepted through protected PR #9 and is on actual main at 7c59df5a006fd809a653b0c3ee10a9d714a91a7f, preserving all ten Lab commits. Its resulting main CI is being verified; a separate green assessment branch does not replace that gate. The hosted media permissions, recording/editing credit, no-reuse exceptions and exclusion of underlying research sources remain satisfactory at current #6 head d0a4d2cadfaee526237146c3c993a1b36ca745dc.
The remaining release handoff is concrete:
- Synchronize this branch from actual corrected main once its four required jobs pass. Maintainer edits are enabled, so the owner can perform the base-only update. Do not replace or squash the original contributor/Lab history.
- Unlock Digital should critically inspect and incorporate the already reviewed Lab release-documentation commit
90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00, currently at upstreammaintainer/demo-authoring-video-2026-10-04. After main synchronization its only content change isCHANGELOG.md: undated v0.2.0 heading, hosted walkthrough item, separate Lab/Unlock credit and presentation/no-reuse terms. Merge that exact commit to retain original Lab authorship and record the assessment in the PR discussion. The later commit was deliberately outside #9 and is not yet on main. No source date is mandatory; publication metadata will record the actual date. - Require all four fresh checks on the resulting exact submission, then owner review/approval. The most recent reviewable push must be approved by a different authorized reviewer under the current rules; keeping this reviewable documentation adoption contributor-pushed allows the owner to provide the counted approval.
This remaining request finalizes the authorized release batch. It identifies no new hosted-media or runtime blocker. Preserve the three hosted media hashes and existing permissions/credits, introduce no underlying collection data, and keep unrelated changes out of this PR. After protected acceptance, the owner will close superseded #8 without merge, review final-main CI and the complete prior-tag range, then publish the conditionally authorized v0.2.0 tag/Release only when those gates pass.
3dhlab
left a comment
There was a problem hiding this comment.
Fresh assessment of actual-main-synchronized head e504fcd04ec53465bb1d967e9eafdec071e070f0. The base-only update includes accepted main 7c59df5a006fd809a653b0c3ee10a9d714a91a7f; its tree exactly equals the reviewed hosted contribution applied to that main. All ten Lab commits, Unlock Digital's assessment and original hosted history remain intact. The eight-file diff retains identical runtime/scripts/CI bytes to main and unchanged MP4/JPEG/GIF hashes. Media exceptions and separate credits pass review; the addressed permission thread is resolved.
Fresh #6 CI 37330260103 passes all four required jobs. Actual main CI 37329352745 also passes all four. GitHub now reports zero open dependency alerts on main. The old-baseline dependency blocker is cleared.
Only remaining source correction before this release-batch acceptance: Unlock Digital critically assesses and merges the exact Lab-authored changelog commit 90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00 from upstream maintainer/demo-authoring-video-2026-10-04, preserving its authorship/history, and records that assessment here. After synchronization this adds only CHANGELOG: the undated finalized v0.2.0 heading, hosted contribution and separate credit/permission boundary. Both independent documentation reviewers already accepted its exact bytes. This commit was deliberately excluded from #9 and is still outside main. Keep the final reviewable adoption contributor-pushed so the owner can provide counted approval under the live last-push rule.
Then rerun the four required jobs on the resulting exact head and obtain fresh owner acceptance. No additional runtime/media/permission correction is requested. The future-release immutability setting is enabled for the requested release freeze, but v0.2.0 remains unpublished until this acceptance and final-main verification complete.
|
Unlock Digital critically assessed and incorporated the Lab's exact release-documentation commit 90a03f1 into the existing fork branch. New submission head: 5dc97c2. Assessment: the undated The source commit is merged intact, retaining its original SHA, Lab author and Lab committer; the adoption merge is authored and committed by Unlock Digital. Relative to reviewed head Validation: public fixture boundary and all four guard regression tests pass; |
|
All four required jobs in fresh CI run 37332428804 pass on exact head 5dc97c2. The assessed Lab changelog commit This exact head is ready for fresh Lab owner review and counted approval. After protected merge, the owner can verify final-main CI/demo, the prior-tag release range and publication metadata before the authorized release. |
3dhlab
left a comment
There was a problem hiding this comment.
Approve exact final contributor head 5dc97c2aa98b3200a1080451c0e752d6e3bfcbc8. I verified the merge of original Lab changelog 90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00, preserving its SHA, raw commit object, author and committer. The adoption merge is separately authored/committed by Unlock Digital. Only CHANGELOG changed since reviewed synchronized head e504fcd; its exact bytes match the independently reviewed Lab text. All ten original Lab commits, independent #9 assessment, original hosted commits and Lab-authored notice history remain intact.
Unlock Digital's critical adoption assessment accurately evaluates the version heading, accepted-main entries, hosted contribution, distinct credits and presentation/no-reuse terms. Its completed review handoff identifies the final checks and owner gates. Root, Sol and Luna independently verified that final tree 58375934f6ec67cee812f13a470c4f02b77e2f37 exactly equals the reviewed complete package. No runtime, dependency, workflow, migration or configuration change is introduced relative to accepted main. All three hosted media hashes are unchanged; permissions/credits/no-reuse exceptions are explicit and the addressed conversation is resolved. Underlying research sources remain excluded.
Fresh final-submission CI 37332428804 passes all four required jobs. Tested PR merge 336918c1 contains exactly the submitted tree. Inspected current artifacts show 624 API cases/31 modules without errors or skips, zero npm audit findings, transcript refresh/conflict/recovery, real seeded private preview/individual publication/cleanup and ordinary/reduced-motion camera continuity within 0.005. The prior source/archive review verifies matching 0.2.0 metadata and valid documentation links.
The remaining requested correction is satisfied. This owner approval accepts the complete contribution for protected merge, preserving separate Lab and Unlock Digital credit/history. After merge, require actual final-main four-job CI and complete prior-tag-range verification, close superseded owner drafts without merging, and bind the already conditionally authorized v0.2.0 tag/immutable Release to that exact verified main commit. No approval of an earlier or unrelated assessment branch is substituted.
The hosted research instance section gives readers a still-image preview, the complete 64.5-second walkthrough with interview audio, and an accessible text guide beside the live collection link. The walkthrough follows Field Museum Spoon through collection filtering, model rotation, annotation playback, Focus view, transcript seeking, citation formats and reopening a shared timestamp. The credited v0.2.0 changelog now covers this hosted contribution alongside the accepted Lab demo and authoring work.
The documentation records the maintainer-confirmed permission to present participants in this edited walkthrough. The MP4, JPEG and GIF are explicitly excluded from Apache 2.0 in LICENSE_STATUS.md, NOTICE and the media guide. Inclusion grants no reuse license for these assets or depicted research content. The edited presentation remains publicly viewable and downloadable; underlying datasets, source interviews and source models remain outside this repository. Original captions and attribution remain visible. Unlock Digital receives recording/editing credit beside the video and in the guide, alongside the separately credited Lab contribution.
Assessment and preserved history
5821b93, preserving Lab authorship and the original Unlock Digital commits.d0a4d2cmakes all three exceptions explicit and links the scope notices beside the README video.7c59df5a006fd809a653b0c3ee10a9d714a91a7fis retained through base-only mergee504fcd. That head passes all four required jobs.90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00, retaining its original SHA, author and committer. Adoption head5dc97c2aa98b3200a1080451c0e752d6e3bfcbc8changes only CHANGELOG.md relative toe504fcd. The exact bytes match the Lab source; credits and permission terms agree with the reviewed docs. The undated version heading prepares the release batch. The detailed assessment is recorded in the PR discussion.Validation and remaining gates
The public fixture boundary and four guard regression tests pass. Relative links and media-permission notices retain the previous checked content. Exact byte comparisons and SHA-256 confirm unchanged MP4, JPEG and GIF assets; application, scripts, dependencies and CI policy remain unchanged.
git diff --checkpasses.Fresh CI run 37332428804 passes all four required jobs on adoption head
5dc97c2aa98b3200a1080451c0e752d6e3bfcbc8. Fresh owner approval on this exact submitted head precedes protected merge. The Lab then verifies final-main CI/demo and the complete prior-tag range before its owner-controlled release. The main update clears the inherited dependency-base prerequisite. Superseded draft #8 cleanup remains with the owner.