Repository navigation
Improve the Lab synthetic demo and visual authoring walkthrough - #7
11 commits merged into
Conversation
A same-video transcript refresh must load fresh text when the editor is clean, while preserving unsaved text during navigation. Track the loaded source baseline, block saving a changed or unavailable source until explicit reconciliation, and cover ingestion, conflict and transcript recovery in the synthetic browser journey.
3dhlab
left a comment
There was a problem hiding this comment.
Independent assessment of Lab head 699b41f3855ceccf366273da686b4909cb2c04e9 against released main 71bfb23c5dc6cfb4c7b724ae7829c56fff928600 is complete.
Sol and Luna independently inspected authoring/playback/refresh behavior and security/data/dependency/CI boundaries. They identified a P2 stale-transcript overwrite risk at the prior head: a successful same-video fetch could display new segments while the clean editor retained old text. The five-path correction refreshes clean drafts, preserves unsaved text, blocks a detected conflict or missing/loading source, and requires confirmed loading of latest text. Both reviewers matched the correction to this exact commit and found no remaining substantiated source blocker in the bounded assessment.
PR CI, branch CI, and combined corrected-baseline CI with #6 each pass all four jobs. The combined artifacts verify 138 web tests under Node 22, 624 API tests/31 modules with no skips, zero npm audit findings, transcript conflict/recovery browser scenarios, real private preview/individual publication/cleanup, and camera continuity under both motion preferences. Auth/public projection, migrations, privileges and media scope were assessed; no hosted or large-collection certification is claimed.
I recommend advancing these exact bytes through the existing contributor path. These are independent agent assessments, not an independent contributor fork submission or counted GitHub approval. Keep this owner draft until an actual contributor critically adopts it, records its own assessment and submits the accepted work from a fork with Lab authorship retained. Main merges, tags and release publication remain held for the owner's separate decision and protected gates.
|
Unlock Digital has verified the requested corrected Lab revision: 699b41f. I am critically assessing that exact revision and will submit it from the Unlock Digital fork with its ten original Lab commits preserved, plus a separate assessment commit. The later release-changelog commit is part of the Lab's continuing release preparation. The independent submission will identify its assessed source precisely so the Lab can continue preparing the release while review is pending. The owner acceptance decision, protected-main checks, and final-main release verification remain the merge and release gates. The assessment will cover the transcript conflict correction, annotation placement and individual publication, reader camera continuity, synthetic refresh protection, dependency changes, and exact-revision CI evidence. I will link the completed assessment and fork submission here. |
3dhlab
left a comment
There was a problem hiding this comment.
Assessed current Lab head 90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00. The sole change after independently assessed code head 699b41f is the finalized credited CHANGELOG. Both independent documentation reviews accepted those exact bytes; all 11 Lab commits retain their original authorship.
Fresh PR CI and branch CI pass all four required jobs. Combined assessment CI also passes at 19ee6e0c4343924a68bb0a307e2c301811cf5fca, including unchanged #6 d0a4d2c. Inspected artifacts confirm 624 API tests without skips, zero npm audit findings, successful transcript conflict/refresh checks and real private preview/individual publication/cleanup. This integration is assessment evidence; actual main remains unchanged.
Unlock Digital will critically adopt and submit the latest corrected Lab work through its fork, with its substantive independent assessment recorded. That contributor submission, fresh exact-head CI and counted owner approval are still required before protected merge. This COMMENT supplies evidence and is not approval of an owner-authored draft.
The owner has conditionally authorized the complete protected Lab-first/#6-second acceptance sequence, closure of superseded #8 without merge, final-main verification and one v0.2.0 tag/Release only after all gates pass. No main merge or publication has occurred.
|
Unlock Digital's independently assessed fork submission is open: #9. It adopts exactly 699b41f and preserves all ten original 3D Humanities Lab commits, SHA values and author/committer identities. The only addition beyond that source is Unlock Digital's critical assessment and release handoff, committed separately at Independent local results: 138 web tests pass, reader and console builds pass, the full npm audit reports zero vulnerabilities, the public fixture guard passes, and regenerated sample chapters decode correctly. Inspected exact-source CI passes all four required jobs and records 624 API tests in 31 modules with zero failures, errors or skips. Its saved real-demo and camera reports verify private projection exclusion, captured placement, individual publication, cleanup and the existing motion tolerance. Fresh CI is running on #9. The bounded assessment found no substantiated blocker for the documented generated-demo/single-range authoring workflow. It records the broader authoring limits, concurrent server-write scope, bounded synthetic-refresh eligibility checks and dependency maintenance follow-up. The Lab can finish release preparation while #9 is pending, including the credited changelog, setup/archive checks and media-permissions integration. The later release-changelog commit stays with that preparation. The owner acceptance decision and all four passing checks on the submitted head precede protected-main merge. Then update #6 from the actual corrected baseline, assess the final permissions/readme contribution, and verify the final main CI/demo and publication date before the owner-controlled tag or Release. |
Superseded Lab review reference; original history preserved through accepted fork contributions. GitHub automatically marked this draft merged when its exact final commit became part of main at
2a4460689d832cb935a1b7014f4b549caeb69566through the protected merge of #6. The original ten Lab commits were independently adopted and accepted through #9; the exact final Lab changelog commit90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00was independently adopted and accepted through #6. Their original SHAs, author and committer identities are retained. No separate merge of this owner-authored draft was performed.The historical proposal and validation below remain a review reference. Final-main CI: https://github.com/3dhlab/loci/actions/runs/37335541720. Superseded permissions draft #8 was closed without merging after its Lab-authored notice was adopted in #6.
Original draft description
The generated demo now explains its three video chapters, supports a visual single-range authoring walkthrough, and preserves the reader's chosen camera when a model pin starts playback. The optional authoring console keeps a mapped range while the user places or refines its point, previews the private annotation, and publishes that annotation individually.
The Lab's full-viewport, silent 40.7-second tutorial is linked from the README with a still poster, timed description, setup guide and provenance. Demo code and tutorial credit belongs to 3D Humanities Lab. Unlock Digital's hosted research walkthrough remains a separate contribution in #6.
Scope and compatibility
Validation
Fresh PR CI and branch CI each pass all four required jobs on
90a03f14a60fdab31e1bd1d86d97cdf1fcf82b00.Combined corrected-baseline CI also passes all four jobs at
19ee6e0c4343924a68bb0a307e2c301811cf5fca, combining this exact Lab head with #6's revised documentation/media head. Its application/scripts/CI bytes equal the Lab head. It is an isolated assessment branch, not a replacement PR or a main merge.Inspected combined-run artifacts and logs show:
Independent Sol and Luna agent assessments identified the stale transcript draft issue, then reassessed the exact correction and found no remaining substantiated source blocker in their bounded reviews. Their ancillary checks are separate from the required CI above; they do not supply counted GitHub approval.
Protected contribution and release path
This remains a draft review reference. Under CONTRIBUTING.md, an actual independent contributor must critically adopt and submit it from a fork, document its assessment and preserve Lab authorship. An owner cannot self-approve this draft; no policy bypass or added writer access is proposed.
The owner has conditionally authorized acceptance and release once the protected gates pass. Unlock Digital will critically adopt and submit the corrected Lab work from its fork, preserving all 11 Lab-authored commits. Merge accepted contributions individually through protected main, update #6 from the actual corrected baseline and re-review its final head, then close #8 as superseded without merge. Verify final-main CI/demo, the full previous-tag range and credited documentation before one owner-controlled v0.2.0 tag and Release. Record the actual publication date in release metadata; a date in source metadata is optional. Broader hosted operations, collection-scale performance, new-object provisioning and general multi-range export remain separate work.
The final changelog-only commit also passed both independent documentation reviews. The latest combined tree differs from the previously inspected code candidate only in CHANGELOG; its five media files are unchanged. All checks linked above are fresh runs for the current heads.