Repository navigation
fix(update): activate new versions without interrupting sign-in - #391
Merged
Merged
Conversation
(cherry picked from commit 9ed4e19f5ea600e185771368c540025df80b11bf)
(cherry picked from commit 5d98f5d8057f788dea8299dceffb540cf67271cc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking One-Click Update starts the build immediately. On macOS and Linux, an installation running from its installed binary switches to the replacement in place after a successful build. The browser waits for the new process to respond, then reloads the update page automatically.
The old process passes token digests and their original expiration times to the replacement through a private file descriptor. The new process resolves permissions from the current RBAC store. Expired and revoked sessions cannot be restored. The first upgrade from an older build that cannot pass sessions may still require one sign-in.
Validation
go build ./...and all 333 frontend tests.TestNonInteractiveStdinReadBlocksWithoutRedirect. It reproduces on upstreammain. The new CI step runs the authentication session tests.