Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model options #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add model options #1

wants to merge 4 commits into from

Conversation

beatrizpinheiro
Copy link

@beatrizpinheiro beatrizpinheiro commented Sep 13, 2024

📑 Description

Changes the RIUNet inference class so it can do the inference with different models, receiving the model name as parameter. Currently with RIUNet and MVLidarNet.

  • Not Completed
  • Completed

✅ Checks

  • I have read the code of conduct file and agree to abide by its rules
  • My pull request adheres to the code style of this project
  • I have updated the documentation as required
  • I have tested the changes locally

@beatrizpinheiro beatrizpinheiro self-assigned this Sep 13, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful not to push cache file.

@@ -29,7 +29,8 @@
tests_require=['pytest'],
entry_points={
'console_scripts': [
'riunet_inf = ufgsim_pkg.riunet_inf:main'
'riunet_inf = ufgsim_pkg.riunet_inf:main',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you removed the riunet_inf.py file, remember to remove this line as well. Otherwise it will be installed as a executable, even though it does not exist.

Copy link
Collaborator

@victormatteus04 victormatteus04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove the cache files and the unnecessary installation of riunet_inf.py on setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants