Open
Conversation
…; implemented reset game button
beccaelenzil
reviewed
Jan 5, 2021
|
|
||
|
|
||
| const checkForWinner = () => { | ||
| const checkForWinner = (newSquares) => { |
There was a problem hiding this comment.
Nice work creating an algorithm with a 2D array.
beccaelenzil
reviewed
Jan 5, 2021
| const oneRow = squares.map ((row) => { | ||
| return row.map ((square) => { | ||
| return ( | ||
| <Square id={square.id} value={square.value} onClickCallback={onClickCallback} currentPlayer={currentPlayer} /> |
There was a problem hiding this comment.
Note the following warning. You should add a key prop to your Square key = {square.id:
Warning: Each child in a list should have a unique "key" prop. See https://reactjs.org/link/warning-keys for more information.
at div
at Board (/app/src/components/Board.js:19:18)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?What are two ways to do "dynamic styling" with React? When should they be used? | Assign className to a component state.
Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content. | Event listener watches for input from the user like a mouse click which then triggers the event handler to update the state of the object. Once the state of the object changes the virtual DOM re-renders that component.
CS Fundamentals Questions
Consider what happens when React processes a state change from
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be. | We don't understand what this is asking