forked from AdaGold/react-tic-tac-toe
-
Notifications
You must be signed in to change notification settings - Fork 37
Christabel-Water-Maha-Earth #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Maha-ElMais
wants to merge
13
commits into
Ada-C14:master
Choose a base branch
from
cescarez:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6bef8d8
tests updated to accurately reflect waves
cescarez 4b56866
npm install
Maha-ElMais 0ef8dfc
wrote generateSquareComponents in Board.js
cescarez 5bce7e9
lifting square state to app
Maha-ElMais db182cb
changed tests to expect uppercase
cescarez 83ff3f7
appropriate characters (x or o) on board, dependent on current player…
cescarez 75057a4
unskipped tests
cescarez febd66e
square values do not update (once set) unless board is reset
cescarez a5c47eb
winner outputs and top left to bottom right diagonal works
cescarez 22c40f9
row winner implemented
cescarez 51a1451
column winner implemented
cescarez e8feb5a
changed logic for setting winner to explicitly set to player (vs usin…
cescarez 986dfef
uncommented tests, changed "winner" header
cescarez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work creating an algorithm with a 2D array.