chore(actions): deprecate the actions moving to dis-way/actions - #3926
Open
arealmaas wants to merge 1 commit into
Open
chore(actions): deprecate the actions moving to dis-way/actions#3926arealmaas wants to merge 1 commit into
arealmaas wants to merge 1 commit into
Conversation
The reusable actions that repositories outside this one consume have been duplicated into dis-way/actions under an altinn/ namespace (dis-way/actions#68). Mark them deprecated here so consumers can migrate. Scope is the five actions with external consumers - terraform/plan (5 repos), terraform/apply (4), flux/build-push-image (8), flux/retag-image (1) and flux/verify-syncroot (3) - plus the three they call internally: terraform/init, terraform/write-terraform-summary and flux/setup-flux-acr. Each deprecated action gains a ::warning:: annotation naming its new location, since external consumers will not read a README, and a README banner. Nothing is removed and no behaviour changes, so existing workflows keep working. flux/setup-flux-acr gets the banner but no runtime warning: it has no direct consumers, so the annotation would only fire transitively and would double up the one already emitted by flux/build-push-image and flux/retag-image. Four actions are not moving and are left untouched: - terraform/plan-only and terraform/apply-only, used only by this repository's k6tests-rg-deploy workflow. - terraform/azure-app-token, which has no consumers anywhere and which dis-way/actions already has its own copy of. - generate-k6-manifests, whose binary is compiled into ghcr.io/altinn/altinn-platform/k6-action-image by infrastructure/images/k6-action/Dockerfile, with this repository's root as build context. Moving the action without that folder would leave Go sources in dis-way/actions that have no effect at runtime. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks the reusable actions that repositories outside this one consume as deprecated. They have been duplicated into
dis-way/actionsunder analtinn/namespace in dis-way/actions#68.Nothing is removed and no behaviour changes — existing workflows keep working. This is purely a signal so consumers can migrate.
Scope
Five actions have external consumers, found via GitHub code search across all repos referencing
Altinn/altinn-platform/actions:flux/build-push-imagealtinn-correspondence,dialogporten-manifests,dialogporten-frontend-manifests,altinn-dashboards-grafana,digdir/ki.norge.no,dis-demo-aalma,dis-demo-vgauk,info.altinn.noterraform/planinfo.altinn.no(×11),altinn-authorization-tmp,dd-infrastructure,altinn-authorization,digdir/dis-syncrootsterraform/applyflux/verify-syncrootdis-demo-aalma,altinn-correspondence,dis-demo-vgaukflux/retag-imagealtinn-correspondencePlus the three they call internally, which have no external consumers of their own but must move for the above to work:
terraform/init,terraform/write-terraform-summary,flux/setup-flux-acr.What each deprecated action gets
::warning::annotation as its first step, naming the new location. This is what actually reaches the external repos — they won't read a README.actions/README.md, which carries the migration table and the reasoning below.flux/setup-flux-acrgets the banner but no runtime warning: it has no direct consumers, so the annotation would only ever fire transitively and would double up the warning already emitted byflux/build-push-imageandflux/retag-image. Itsaction.yamlis unchanged.Four actions are not moving, and are untouched here
terraform/plan-onlyandterraform/apply-only— used only by this repository's ownk6tests-rg-deployworkflow. Nothing outsidealtinn-platformreferences them.terraform/azure-app-token— no consumers anywhere, in this repo or any other.dis-way/actionsalready has its own copy.generate-k6-manifests— its binary is not built from the sources in that folder at action runtime. It is compiled intoghcr.io/altinn/altinn-platform/k6-action-imagebyinfrastructure/images/k6-action/Dockerfile, whose build context is this repository's root; the action's ownDockerfileonly layersgenerate.shon top. The generator also resolvesghcr.io/altinn/altinn-platform/k6-imageas the k6 runner and reads cluster config baked into the image at/actions/generate-k6-manifests/infra/. Moving it withoutinfrastructure/images/k6-action/would produce a repo where editing the Go sources changes nothing at runtime — a trap rather than a migration.Migrating a workflow
Replace the
uses:path and keep thewith:block unchanged:Caution
Do not repoint at
dis-way/actions/terraform/plan(withoutaltinn/). That is a different, independently developed action — different Azure storage account, resource group and subscription for Terraform state, and a different state-key format. Unknown inputs are only a warning in GitHub Actions, not an error, so a wrong path silently falls back to defaults and plans against an empty state.actions/README.mdspells this out.Sequencing
dis-way/actions#68 should merge first, and its internal action references bumped to the merged SHA, before anyone acts on these warnings — the
dis-way/actions/altinn/...paths do not resolve until then.Verification
mainactionlintreports 0 findings underactions/🤖 Generated with Claude Code