Skip to content

chore(actions): deprecate the actions moving to dis-way/actions - #3926

Open
arealmaas wants to merge 1 commit into
mainfrom
arealmaas/riga-v1
Open

chore(actions): deprecate the actions moving to dis-way/actions#3926
arealmaas wants to merge 1 commit into
mainfrom
arealmaas/riga-v1

Conversation

@arealmaas

Copy link
Copy Markdown
Contributor

Marks the reusable actions that repositories outside this one consume as deprecated. They have been duplicated into dis-way/actions under an altinn/ namespace in dis-way/actions#68.

Nothing is removed and no behaviour changes — existing workflows keep working. This is purely a signal so consumers can migrate.

Scope

Five actions have external consumers, found via GitHub code search across all repos referencing Altinn/altinn-platform/actions:

Action External consumer repos
flux/build-push-image 8 — altinn-correspondence, dialogporten-manifests, dialogporten-frontend-manifests, altinn-dashboards-grafana, digdir/ki.norge.no, dis-demo-aalma, dis-demo-vgauk, info.altinn.no
terraform/plan 5 — info.altinn.no (×11), altinn-authorization-tmp, dd-infrastructure, altinn-authorization, digdir/dis-syncroots
terraform/apply 4 — same cluster, 16 refs
flux/verify-syncroot 3 — dis-demo-aalma, altinn-correspondence, dis-demo-vgauk
flux/retag-image 1 — altinn-correspondence

Plus the three they call internally, which have no external consumers of their own but must move for the above to work: terraform/init, terraform/write-terraform-summary, flux/setup-flux-acr.

What each deprecated action gets

  • A ::warning:: annotation as its first step, naming the new location. This is what actually reaches the external repos — they won't read a README.
  • A README banner. Five of them had no README, so those were created.
  • An entry in the new actions/README.md, which carries the migration table and the reasoning below.

flux/setup-flux-acr gets the banner but no runtime warning: it has no direct consumers, so the annotation would only ever fire transitively and would double up the warning already emitted by flux/build-push-image and flux/retag-image. Its action.yaml is unchanged.

Four actions are not moving, and are untouched here

  • terraform/plan-only and terraform/apply-only — used only by this repository's own k6tests-rg-deploy workflow. Nothing outside altinn-platform references them.
  • terraform/azure-app-token — no consumers anywhere, in this repo or any other. dis-way/actions already has its own copy.
  • generate-k6-manifests — its binary is not built from the sources in that folder at action runtime. It is compiled into ghcr.io/altinn/altinn-platform/k6-action-image by infrastructure/images/k6-action/Dockerfile, whose build context is this repository's root; the action's own Dockerfile only layers generate.sh on top. The generator also resolves ghcr.io/altinn/altinn-platform/k6-image as the k6 runner and reads cluster config baked into the image at /actions/generate-k6-manifests/infra/. Moving it without infrastructure/images/k6-action/ would produce a repo where editing the Go sources changes nothing at runtime — a trap rather than a migration.

Migrating a workflow

Replace the uses: path and keep the with: block unchanged:

-  uses: Altinn/altinn-platform/actions/terraform/plan@<hash>
+  uses: dis-way/actions/altinn/terraform/plan@<hash>

Caution

Do not repoint at dis-way/actions/terraform/plan (without altinn/). That is a different, independently developed action — different Azure storage account, resource group and subscription for Terraform state, and a different state-key format. Unknown inputs are only a warning in GitHub Actions, not an error, so a wrong path silently falls back to defaults and plans against an empty state. actions/README.md spells this out.

Sequencing

dis-way/actions#68 should merge first, and its internal action references bumped to the merged SHA, before anyone acts on these warnings — the dis-way/actions/altinn/... paths do not resolve until then.

Verification

  • All 12 action files still parse; the four non-moving ones are byte-identical to main
  • actionlint reports 0 findings under actions/
  • All relative links in the new and edited READMEs resolve

🤖 Generated with Claude Code

The reusable actions that repositories outside this one consume have been
duplicated into dis-way/actions under an altinn/ namespace
(dis-way/actions#68). Mark them deprecated here so consumers can migrate.

Scope is the five actions with external consumers - terraform/plan (5
repos), terraform/apply (4), flux/build-push-image (8), flux/retag-image
(1) and flux/verify-syncroot (3) - plus the three they call internally:
terraform/init, terraform/write-terraform-summary and flux/setup-flux-acr.

Each deprecated action gains a ::warning:: annotation naming its new
location, since external consumers will not read a README, and a README
banner. Nothing is removed and no behaviour changes, so existing
workflows keep working.

flux/setup-flux-acr gets the banner but no runtime warning: it has no
direct consumers, so the annotation would only fire transitively and
would double up the one already emitted by flux/build-push-image and
flux/retag-image.

Four actions are not moving and are left untouched:

- terraform/plan-only and terraform/apply-only, used only by this
  repository's k6tests-rg-deploy workflow.
- terraform/azure-app-token, which has no consumers anywhere and which
  dis-way/actions already has its own copy of.
- generate-k6-manifests, whose binary is compiled into
  ghcr.io/altinn/altinn-platform/k6-action-image by
  infrastructure/images/k6-action/Dockerfile, with this repository's root
  as build context. Moving the action without that folder would leave Go
  sources in dis-way/actions that have no effect at runtime.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e5670dd-1656-4056-8eff-4786a5b502f6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant