Skip to content

Conversation

@JacobAdamsen
Copy link
Contributor

@JacobAdamsen JacobAdamsen commented Sep 15, 2025

Merging some commits from the branch "master.anybody.8.2" into the master branch.
Changes regarding the tutorials "Making Things Move" (given new name "Motion Capture Movement") and "How to Write AnyScript" have been merged into the Master branch.

All updates in the tutorial "Motion Capture Movement" are primarily taken from the pull request #46 and includes:

  • New name for tutorial
  • Original lesson 1 is deleted - the content is now included in the How to Write AnyScript" tutorial"
  • Original lesson 5 is moved up to be lesson 1 now
  • Code snippets are added to enable test

All updates in the tutorial "How to Write AynScript" are primarily taken from the pull request #42 and includes:

  • Uses "AnyKinDriver" instead of AnyKinEqSimpleDriver"
  • Added a new section about AnyKinMotion in Lesson 5

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges commits from the "master.anybody.8.2" branch into master, focusing on two main tutorial updates. It renames the "Making Things Move" tutorial to "Motion Capture Movement" and incorporates changes from earlier pull requests #46 and #42. The changes primarily involve updating AnyScript syntax and improving documentation formatting across tutorial lessons.

Key changes include:

  • Migration from deprecated AnyKinEqSimpleDriver to AnyKinDriver class with updated parameter names
  • Improved text formatting and line wrapping for better readability
  • Addition of new content about AnyKinMotion driver as an alternative option

Reviewed Changes

Copilot reviewed 51 out of 151 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
A_Getting_started_anyscript/lesson6.md Text reformatting and line wrapping improvements
A_Getting_started_anyscript/lesson5.md Text formatting, expanded AnyKinMotion section, reorganized external loads content
A_Getting_started_anyscript/lesson4.md Text formatting and driver class name updates
Multiple snippet files Updated AnyScript syntax from AnyKinEqSimpleDriver to AnyKinDriver with new parameter names
A_Getting_started/intro.md Fixed header formatting from # to ##

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 68 to 71
belonging to the `AnyKinDriver ` class.

**All AnyBody drivers only work on the measures that are supplied to them. The** `AnyKinEqSimpleDriver` **class used in this case, constrains
the supplied measure's positions to a given value at time = 0 (`DriverPos`) and changes this position at constant velocity thereon (`DriverVel`).**
**All AnyBody drivers only work on the measures that are supplied to them**. The
`AnyKinDriver ` class used in this case, constrains the supplied
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space after AnyKinDriver in the class name. It should be AnyKinDriver without the trailing space.

Copilot uses AI. Check for mistakes.
Comment on lines +319 to +321
Applied forces do not have to be constant. They can change with time and other
properties in the model. Please refer to the
{doc}`tutorial on forces<../The_mechanical_elements/intro>` for more details.
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces after 'model.' on line 320, but only one space is needed. Additionally, there should be a space before the opening angle bracket in the doc reference on line 321.

Copilot uses AI. Check for mistakes.
@melund melund merged commit ab67a3d into master Oct 13, 2025
16 checks passed
Copy link

@Hamedshayestehpour Hamedshayestehpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not get time to review all the changes, but in the overall view, it looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants