Open
Conversation
Use MIME type decoder here to be compatible with the old serialization result stored in entity's inventory PDC.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snakeyaml deprecated the external util class
Base64Codersince snakeyaml 2.3It replaced it using Java's built-in Base64 util (
java.util.Base64), which is better and more standard. So, for the consideration of the future, it is not appropriate to continue relying on snakeyaml'sBase64Coderutil class.In here, I use
Base64.getMimeDecoder()for the base64 decoding, to be compatible with old data stored in entity inventory's PDC that is using the old standard (theBase64Coderis using MIME type).And use the basic Base64 encoder to encode the item.