Skip to content

Refactor item to base64 serialization #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dreeam-qwq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor item to base64 serialization #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/me/athlaeos/valhallatrinkets/ItemSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
import org.bukkit.inventory.ItemStack;
import org.bukkit.util.io.BukkitObjectInputStream;
import org.bukkit.util.io.BukkitObjectOutputStream;
import org.yaml.snakeyaml.external.biz.base64Coder.Base64Coder;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.util.Base64;

public class ItemSerializer {
public static String toBase64(ItemStack itemStack) throws IllegalStateException {
Expand All @@ -20,7 +20,7 @@ public static String toBase64(ItemStack itemStack) throws IllegalStateException

// Serialize that array
dataOutput.close();
return Base64Coder.encodeLines(outputStream.toByteArray());
return Base64.getEncoder().encodeToString(outputStream.toByteArray());
} catch (Exception e) {
ValhallaTrinkets.getPlugin().getServer().getLogger().severe("Unable to save itemstack from encoded data");
throw new IllegalStateException("Unable to save item stacks.", e);
Expand All @@ -29,7 +29,7 @@ public static String toBase64(ItemStack itemStack) throws IllegalStateException

public static ItemStack itemStackFromBase64(String data) {
try {
ByteArrayInputStream inputStream = new ByteArrayInputStream(Base64Coder.decodeLines(data));
ByteArrayInputStream inputStream = new ByteArrayInputStream(Base64.getMimeDecoder().decode(data));
BukkitObjectInputStream dataInput = new BukkitObjectInputStream(inputStream);

ItemStack i = (ItemStack) dataInput.readObject();
Expand Down