Skip to content

A4A Client: defer connection check to plugins_loaded hook #46062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

A4A Client: defer connection check to plugins_loaded hook #46062

wants to merge 1 commit into from

Conversation

@vitozev
Copy link
Contributor

@vitozev vitozev commented Nov 24, 2025 •
edited
Loading

Fixes #

Proposed changes:

Problem

The A4A Client plugin experiences fatal errors on Atomic sites because $manager->is_connected() runs too early in init(), before WordPress core functions like get_user_by() are available. This was introduced in PR #37337.

Solution

Move the connection check from init() to the plugins_loaded hook (priority 20) so:

  • WordPress core functions are available
  • Connection package is initialized first (priority 1)
  • Deactivation handler still initializes early enough

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with the A4A client plugin installed on top of this branch (e.g., /wp-admin/admin.php?page=jetpack-beta&plugin=automattic-for-agencies-client)
  • With a disconnected site, deactivate the plugin. Verify no interstitial connection pop-up is shown and the plugin deactivates right away.
  • Re-activate the plugin, and connect the site.
  • Deactivate the plugin, verify the disconnect dialog pops up before deactivating the plugin.

@vitozev
A4A Client: defer connection check to plugins_loaded hook
fbbb045 
Move the connection check from init() to plugins_loaded hook to prevent
fatal errors when WordPress core functions (like get_user_by) are not
yet available. This fixes an issue introduced in PR #37337 where
the connection check ran too early in the plugin initialization.

Fixes a bug where the connection check would run before WordPress core
functions are loaded, causing fatal errors in environments like Atomic
where get_user_by() is used by the connection check.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Nov 24, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Nov 24, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/automattic-for-agencies-client/src/class-automattic-for-agencies-client.php 0/57 (0.00%) 0.00% 1 ❤️‍🩹

Full summary · PHP report · JS report

@vitozev vitozev marked this pull request as ready for review November 24, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgiannar fgiannar Awaiting requested review from fgiannar

@bindlegirl bindlegirl Awaiting requested review from bindlegirl

Assignees

No one assigned

Labels

[Plugin] Automattic For Agencies Client [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitozev