Skip to content

A4A Client: defer connection check to plugins_loaded hook #46062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
+18 −0
Open

A4A Client: defer connection check to plugins_loaded hook #46062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions projects/plugins/automattic-for-agencies-client/changelog/fix-a4a-defer-connection-check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: fixed

A4A Client: defer connection check to plugins_loaded hook to prevent fatal errors when WordPress core functions are not yet available.

13 changes: 13 additions & 0 deletions projects/plugins/automattic-for-agencies-client/src/class-automattic-for-agencies-client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,19 @@ public static function init() {
add_action( 'load-settings_page_' . AUTOMATTIC_FOR_AGENCIES_CLIENT_SLUG, array( static::class, 'load_scripts_styles' ) );

// Display a modal when trying to deactivate the plugin.
// Hook to plugins_loaded at priority 20 to ensure connection package is initialized
// and WordPress core functions (like get_user_by) are available.
add_action( 'plugins_loaded', array( static::class, 'init_deactivation_handler' ), 20 );
}

/**
* Initialize the deactivation handler if the site is connected.
*
* @since 0.1.0
*
* @return void
*/
public static function init_deactivation_handler() {
$manager = new Connection_Manager( 'automattic-for-agencies-client' );
if ( $manager->is_connected() ) {
Deactivation_Handler::init( AUTOMATTIC_FOR_AGENCIES_CLIENT_SLUG, __DIR__ . '/admin/deactivation-dialog.php' );
Expand Down
Loading