update: usage of WP best practices #11137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
commented
Nov 18, 2025
| * @return string | ||
| */ | ||
| function format_price_helper( array $product, string $currency ): string { | ||
| function wcpay_format_price_helper( array $product, string $currency ): string { |
Contributor
Author
There was a problem hiding this comment.
Despite this function being inside of a template, it looks like we still need to prefix it with a wcpay_ prefix, otherwise WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound fails
|
|
||
| $wpdb->query( | ||
| $wpdb->prepare( | ||
| "INSERT INTO $this->table (`session_key`, `session_value`, `session_expiry`) VALUES (%s, %s, %d) ON DUPLICATE KEY UPDATE `session_value` = VALUES(`session_value`), `session_expiry` = VALUES(`session_expiry`)", // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared |
Contributor
Author
There was a problem hiding this comment.
Here I just moved the phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared comment before the query. It looks like some linters might fail it.
| // This allows WC to check if WP_DEBUG mode is enabled before returning previous Exception and expose Exception class name to frontend. | ||
| add_filter( 'woocommerce_return_previous_exceptions', '__return_true' ); | ||
| wc_add_notice( wp_strip_all_tags( WC_Payments_Utils::get_filtered_error_message( $e, $blocked_by_fraud_rules ) ), 'error' ); | ||
| do_action( 'update_payment_result_on_error', $e, $order ); |
Contributor
Author
There was a problem hiding this comment.
The only usage of update_payment_result_on_error is in our codebase. I verified it with this:
- https://github.com/search?q=org%3AAutomattic%20update_payment_result_on_error&type=code
- https://github.com/search?q=org%3Awoocommerce+update_payment_result_on_error&type=code
So I think it's safe to rename this hook to have a wcpay_ prefix.
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: 0 B Total Size: 875 kB ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5509
Changes proposed in this Pull Request
Fixing some of the WP plugin best practices.
Testing instructions
Nothing changes here.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge