update: usage of WP best practices

changelog/fix-pluginscore-ratings

@@ -0,0 +1,4 @@
+Significance: patch
+Type: update
+
+update: usage of WP best practices

includes/class-wc-payment-gateway-wcpay.php

@@ -1266,7 +1266,7 @@ public function process_payment( $order_id ) {
 			// This allows WC to check if WP_DEBUG mode is enabled before returning previous Exception and expose Exception class name to frontend.
 			add_filter( 'woocommerce_return_previous_exceptions', '__return_true' );
 			wc_add_notice( wp_strip_all_tags( WC_Payments_Utils::get_filtered_error_message( $e, $blocked_by_fraud_rules ) ), 'error' );
-			do_action( 'update_payment_result_on_error', $e, $order );
+			do_action( 'wcpay_update_payment_result_on_error', $e, $order );
 
 			return [
 				'result'   => 'fail',
@@ -1340,15 +1340,15 @@ public function update_customer_with_order_data( $order, $customer_id, $is_test_
 
 	/**
 	 * Sets up a handler to add error details to the payment result.
-	 * Registers an action to handle 'update_payment_result_on_error',
+	 * Registers an action to handle 'wcpay_update_payment_result_on_error',
 	 * using the payment result object from 'woocommerce_rest_checkout_process_payment_with_context'.
 	 *
 	 * @param PaymentContext $context The payment context.
 	 * @param PaymentResult  $result  The payment result, passed by reference.
 	 */
 	public function setup_payment_error_handler( PaymentContext $context, PaymentResult &$result ) {
 		add_action(
-			'update_payment_result_on_error',
+			'wcpay_update_payment_result_on_error',
 			function ( $error ) use ( &$result ) {
 				$result->set_payment_details(
 					array_merge(

includes/in-person-payments/templates/html-in-person-payment-receipt.php

@@ -12,7 +12,7 @@
  * @param  string $currency The currency to display.
  * @return string
  */
-function format_price_helper( array $product, string $currency ): string {
+function wcpay_format_price_helper( array $product, string $currency ): string {
 	$active_price  = $product['price'];
 	$regular_price = $product['regular_price'];
 	$has_discount  = $active_price !== $regular_price;
@@ -139,7 +139,7 @@ function format_price_helper( array $product, string $currency ): string {
 				<tr>
 					<td class="align-left">
 						<div><?php echo esc_html( $item['name'] ); ?></div>
-						<div><?php echo esc_html( $item['quantity'] ); ?> @ <?php echo wp_kses( format_price_helper( $item['product'], $order['currency'] ), 'post' ); ?></div>
+						<div><?php echo esc_html( $item['quantity'] ); ?> @ <?php echo wp_kses( wcpay_format_price_helper( $item['product'], $order['currency'] ), 'post' ); ?></div>
 						<div><?php printf( '%s: %s', esc_html__( 'SKU', 'woocommerce-payments' ), esc_html( $item['product']['id'] ) ); ?></div> <!-- TODO SKU or ID? -->
 					</td>
 					<td class="align-right align-top"><?php echo wp_kses( wc_price( $item['subtotal'], [ 'currency' => $order['currency'] ] ), 'post' ); ?></td>

includes/notes/class-wc-payments-remote-note-service.php

@@ -113,11 +113,10 @@ private function create_note( array $note_data ) {
 	 */
 	public function delete_notes() {
 		global $wpdb;
-		$prefix = self::NOTE_NAME_PREFIX;
-		// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
-		$wpdb->query( "DELETE FROM {$wpdb->prefix}wc_admin_note_actions WHERE name LIKE '{$prefix}%'" );
-		// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared, WordPress.DB.PreparedSQL.InterpolatedNotPrepared
-		$wpdb->query( "DELETE FROM {$wpdb->prefix}wc_admin_notes WHERE name LIKE '{$prefix}%'" );
+		// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
+		$wpdb->query( $wpdb->prepare( "DELETE FROM {$wpdb->prefix}wc_admin_note_actions WHERE name LIKE %s", $wpdb->esc_like( self::NOTE_NAME_PREFIX ) . '%' ) );
+		// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
+		$wpdb->query( $wpdb->prepare( "DELETE FROM {$wpdb->prefix}wc_admin_notes WHERE name LIKE %s", $wpdb->esc_like( self::NOTE_NAME_PREFIX ) . '%' ) );
 	}
 
 	/**

includes/woopay/class-woopay-store-api-session-handler.php

@@ -112,7 +112,8 @@ public function save_data() {
 
 			$wpdb->query(
 				$wpdb->prepare(
-					"INSERT INTO $this->table (`session_key`, `session_value`, `session_expiry`) VALUES (%s, %s, %d) ON DUPLICATE KEY UPDATE `session_value` = VALUES(`session_value`), `session_expiry` = VALUES(`session_expiry`)", // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
+					// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
+					"INSERT INTO $this->table (`session_key`, `session_value`, `session_expiry`) VALUES (%s, %s, %d) ON DUPLICATE KEY UPDATE `session_value` = VALUES(`session_value`), `session_expiry` = VALUES(`session_expiry`)",
 					$this->_customer_id,
 					maybe_serialize( $this->_data ),
 					$this->session_expiration

tests/unit/notes/test-class-wc-payments-remote-note-service.php

@@ -140,4 +140,36 @@ public function test_throws_on_malformed_data() {
 		$this->expectException( Rest_Request_Exception::class );
 		$this->note_service->put_note( $note_data );
 	}
+
+	public function test_delete_notes() {
+		global $wpdb;
+
+		$real_data_store = WC_Data_Store::load( 'admin-note' );
+		$note_service    = new WC_Payments_Remote_Note_Service( $real_data_store );
+
+		$note_data = [
+			'title'   => 'test',
+			'content' => 'hello_world',
+		];
+
+		$note_service->put_note( $note_data );
+
+		$notes_before = $wpdb->get_var(
+			$wpdb->prepare(
+				"SELECT COUNT(*) FROM {$wpdb->prefix}wc_admin_notes WHERE name LIKE %s",
+				'wc-payments-remote-notes-%'
+			)
+		);
+		$this->assertEquals( 1, $notes_before );
+
+		$note_service->delete_notes();
+
+		$notes_after = $wpdb->get_var(
+			$wpdb->prepare(
+				"SELECT COUNT(*) FROM {$wpdb->prefix}wc_admin_notes WHERE name LIKE %s",
+				'wc-payments-remote-notes-%'
+			)
+		);
+		$this->assertEquals( 0, $notes_after );
+	}
 }