Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EngSys] Drop support for Node 18 #32576

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[EngSys] Drop support for Node 18 #32576

merged 5 commits into from
Mar 5, 2025

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented Feb 12, 2025 •
edited
Loading

Merge soon, since TSP is dropping soon: microsoft/typespec#5977

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 12, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Feb 12, 2025 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

timotheeguerin
timotheeguerin approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary just yet as I am downgrading arborist but something we'll have to do next month otherwise

@mikeharder mikeharder self-assigned this Feb 12, 2025
@mikeharder mikeharder marked this pull request as ready for review March 5, 2025 02:09
@mikeharder mikeharder merged commit cc10080 into Azure:main Mar 5, 2025
44 of 46 checks passed
@mikeharder mikeharder deleted the drop-node-18 branch March 5, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@mikeharder mikeharder

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @timotheeguerin