Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] Drop support for Node 18 #32576

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[EngSys] Drop support for Node 18 #32576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e65eb1
Drop support for Node 18
mikeharder Feb 12, 2025
033ef08
Merge branch 'main' into drop-node-18
mikeharder Mar 5, 2025
83e32f6
npm update
mikeharder Mar 5, 2025
6de1912
Update minimatch
mikeharder Mar 5, 2025
1b987d0
npm update
mikeharder Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: 2

Check failure on line 1 in .github/dependabot.yml

View workflow job for this annotation

GitHub Actions / Protected Files 

File '.github/dependabot.yml' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
updates:
- package-ecosystem: "npm"
directories:
Expand All @@ -16,9 +16,6 @@
- dependency-name: "typescript"
# Updated manually by the Liftr team
- dependency-name: "@azure-tools/typespec-liftr-base"
# minimatch@9 is the last version to support Node 18
- dependency-name: "minimatch"
versions: [">= 10.0.0"]
groups:
# Ships separately from other typespec packages
typespec-client-generator-cli:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/_reusable-eng-tools-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Prefix with "~" to sort last in Actions list

Check failure on line 1 in .github/workflows/_reusable-eng-tools-test.yaml

View workflow job for this annotation

GitHub Actions / Protected Files 

File '.github/workflows/_reusable-eng-tools-test.yaml' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
name: ~Templates - eng/tools - Test

on:
Expand Down Expand Up @@ -28,12 +28,12 @@
strategy:
matrix:
os: [ubuntu, windows]
node-version: [18, 22]
node-version: [20, 22]
exclude:
- os: ubuntu
node-version: 22
- os: windows
node-version: 18
node-version: 20

runs-on: ${{ fromJSON('{"ubuntu":"ubuntu-24.04", "windows":"windows-2022"}')[matrix.os] }}

Expand Down
2 changes: 1 addition & 1 deletion eng/tools/sdk-suppressions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/sdk-suppressions/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/sdk-suppressions/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/sdk-suppressions",
"private": true,
"type": "module",
Expand All @@ -13,7 +13,7 @@
"test:ci": "vitest run --coverage --reporter=verbose"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
},
"dependencies": {
"ajv": "^8.17.1",
Expand Down
2 changes: 1 addition & 1 deletion eng/tools/specs-model/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/specs-model/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/specs-model/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/specs-model",
"private": true,
"type": "module",
Expand All @@ -17,7 +17,7 @@
"prettier:write": "prettier . --write"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
},
"dependencies": {},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions eng/tools/suppressions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/suppressions/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/suppressions/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/suppressions",
"private": true,
"type": "module",
Expand All @@ -12,10 +12,10 @@
"test:ci": "vitest run --coverage --reporter=verbose"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
},
"dependencies": {
"minimatch": "^9.0.4",
"minimatch": "^10.0.1",
"yaml": "^2.4.2",
"zod": "^3.23.8",
"zod-validation-error": "^3.3.0"
Expand Down
2 changes: 1 addition & 1 deletion eng/tools/tsp-client-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/tsp-client-tests/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/tsp-client-tests/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/tsp-client-tests",
"private": true,
"type": "module",
Expand All @@ -14,6 +14,6 @@
"test:ci": "vitest run --reporter=verbose"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
}
}
2 changes: 1 addition & 1 deletion eng/tools/typespec-requirement/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/typespec-requirement/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/typespec-requirement/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/typespec-requirement",
"private": true,
"type": "module",
Expand All @@ -14,6 +14,6 @@
"test:ci": "vitest run --reporter=verbose"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
}
}
2 changes: 1 addition & 1 deletion eng/tools/typespec-validation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in eng/tools/typespec-validation/package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'eng/tools/typespec-validation/package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "@azure-tools/typespec-validation",
"private": true,
"type": "module",
Expand All @@ -24,6 +24,6 @@
"test:ci": "vitest run --coverage --reporter=verbose"
},
"engines": {
"node": ">= 18.0.0"
"node": ">=20.0.0"
}
}
106 changes: 74 additions & 32 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in package.json

View workflow job for this annotation

GitHub Actions / Protected Files 

File 'package.json' should only be updated by the Azure SDK team.  If intentional, the PR may be merged by the Azure SDK team via bypassing the branch protections.
"name": "azure-rest-api-specs",
"devDependencies": {
"@azure-tools/typespec-apiview": "0.5.1",
Expand Down Expand Up @@ -27,8 +27,8 @@
"typescript": "~5.6.2"
},
"engines": {
"node": ">=18.0.0",
"npm": ">=9.0.0"
"node": ">=20.0.0",
"npm": ">=10.0.0"
},
"private": true
}
Loading