Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kamboj prjwl/release network microsoft.network 2024 07 01 #33072

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

d139ee5
Select commit
Loading
Failed to load commit list.
Open

Kamboj prjwl/release network microsoft.network 2024 07 01 #33072

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…
d139ee5
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff failed Mar 8, 2025 in 34m 25s

Swagger LintDiff failed

LintDiff: 1742 Errors, 1275 Warnings
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.3) new version base version
package-2024-05 package-2024-05(d139ee5) package-2024-05(main)
package-2024-06-preview package-2024-06-preview(d139ee5) package-2024-06-preview(main)
package-2024-07-01 package-2024-07-01(d139ee5) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Network/stable/2024-07-01/network.json#L233
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Network/stable/2024-07-01/networkVerifier.json#L1062
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Network/stable/2024-07-01/networkVerifier.json#L1132
❌ SystemDataDefinitionsCommonTypes System data references must utilize common types.
Location: Microsoft.Network/stable/2024-07-01/networkVerifier.json#L1205
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2024-07-01/networkWatcher.json#L2013		 RPC-Patch-V1-11
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L235		 RPC-Patch-V1-11
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.Network/stable/2024-07-01/ipAddressManager.json#L8		 RPC-Get-V1-11
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: Microsoft.Network/stable/2024-07-01/networkManagerConnectivityConfiguration.json#L301
⚠️ OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NspAssociationReconcileModel'. Consider using the plural form of 'NspAssociationReconcile' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.Network/stable/2024-07-01/networkSecurityPerimeter.json#L843
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'reconcile' in:'NspAssociationReconcile_Post'. Consider updating the operationId
Location: Microsoft.Network/stable/2024-07-01/networkSecurityPerimeter.json#L843
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.Network/stable/2024-07-01/networkVerifier.json#L592		 RPC-Get-V1-11
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-07-01/networkVirtualAppliance.json#L372
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-07-01/networkVirtualAppliance.json#L445
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Network/stable/2024-07-01/networkVirtualAppliance.json#L1737
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L929
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L998
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3873
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3898
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3938
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3955
⚠️ LocationMustHaveXmsMutability Property location must have 'x-ms-mutability':['read', 'create'] extension defined.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3966		 RPC-Put-V1-14
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3972
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L3988
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-07-01/virtualNetworkGateway.json#L4013
⚠️ XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Network/stable/2024-07-01/webapplicationfirewall.json#L811


The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L37
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L37
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L38
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L38
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L70
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L70
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L99
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L99
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LoadBalancers_CreateOrUpdate' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L151
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LoadBalancers_CreateOrUpdate' Request Model: 'parameters[2].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L151
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L388
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L388
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L444
❌ ResourceNameRestriction The resource name parameter 'backendAddressPoolName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L444
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L444
❌ ResourceNameRestriction The resource name parameter 'backendAddressPoolName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L444
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LoadBalancerBackendAddressPools_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L503
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'LoadBalancerBackendAddressPools_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L503
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L577
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L577
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L616
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L616
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L640
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L640
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L693
❌ ResourceNameRestriction The resource name parameter 'frontendIPConfigurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L693
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L693
❌ ResourceNameRestriction The resource name parameter 'frontendIPConfigurationName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L693
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L750
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L750
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L803
❌ ResourceNameRestriction The resource name parameter 'inboundNatRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L803
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L803
❌ ResourceNameRestriction The resource name parameter 'inboundNatRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L803
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L804
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L804
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L843
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L843
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L872
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L872
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'InboundNatRules_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L928
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'InboundNatRules_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L928
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1003
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1003
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1056
❌ ResourceNameRestriction The resource name parameter 'loadBalancingRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1056
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1056
❌ ResourceNameRestriction The resource name parameter 'loadBalancingRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1056
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1113
❌ ResourceNameRestriction The resource name parameter 'loadBalancerName' should be defined with a 'pattern' restriction.
Location: Microsoft.Network/stable/2024-05-01/loadBalancer.json#L1113
View more details on openapi-pipeline-app