Update package versions and local path dependencies #2247
Conversation
hallipr
commented
Feb 26, 2025
•
hallipr
commented
- root/workspace Cargo.toml should only reference released versions for dependencies
- this allows packages in the repo to take workspaces references and release with stable dependencies
- all /Cargo.toml versions should normally reflect the next unreleased prerelease version
- the repo is in a continuous state of preparing the next release of any given package.
- a package shouldn't have changes in its source while keeping the same version number as a released version
- any package that needs to depend on another unreleased package should take a path dependency to the unreleased package, not a workspace dependency
hallipr
requested review from
heaths,
RickWinter,
JeffreyRichter,
LarryOsterman,
vincenttran-msft,
jalauzon-msft and
ronniegeraghty
as code owners
github-actions
bot
added
Azure.Core
| @@ -29,41 +29,23 @@ rust-version = "1.80" | |||
|
|
|||
| [workspace.dependencies.typespec] | |||
| default-features = false | |||
| path = "sdk/typespec" | |||
There was a problem hiding this comment.
Is this what we decided to do? I thought we were going to leave both. This really needs to be written up somewhere and not locked in our heads. We've waffled about this too much.
That said, this is maybe premature because:
- We should test
package-workspaceand help stabilize that. Seems it'll solve most of our problems and we won't have to have this difficult solution. - Until GA, we'll be rev'ing everything anyway. beta.2 is going to include a massive number of changes because I'm changing
azure_coresignificantly.
There was a problem hiding this comment.
If anything, maybe we should be keeping the path dependency for the foreseeable future.
There was a problem hiding this comment.
What will we do about late shippers? If workspace is a path dependency and Cosmos takes a workspace dependency, then we can't change core/typespec packages until after cosmos ships. This could block changes in core or typespec for weeks at a time
sdk/core/azure_core/Cargo.toml
Outdated
| @@ -28,8 +28,11 @@ serde_json.workspace = true | |||
| sha2 = { workspace = true, optional = true } | |||
| tokio = { workspace = true, optional = true } | |||
| tracing.workspace = true | |||
| typespec = { workspace = true, features = ["http", "json"] } | |||
| typespec_client_core = { workspace = true, features = ["http", "json"] } | |||
| typespec = { path = "../../typespec", features = ["http", "json"] } | |||
There was a problem hiding this comment.
I think all crates should be using path dependencies until GA (or close). See previous comments.
hallipr
force-pushed
the
users/pahallis/versions
branch
from
8a3040e to
285ed44
Compare
hallipr
force-pushed
the
users/pahallis/versions
branch
from
285ed44 to
6aacee0
Compare
hallipr
force-pushed
the
users/pahallis/versions
branch
from
6aacee0 to
f60c6ae
Compare
| @@ -18,7 +18,7 @@ categories = ["api-bindings"] | |||
| edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| azure_core = { path = "../azure_core", default-features = false } | |||
| azure_core = { path = "../azure_core", version = "0.23.0", default-features = false } | |||
There was a problem hiding this comment.
Versions should only be in the workspace Cargo.toml. I don't want to manager versions across a swatch of files.
There was a problem hiding this comment.
anything with a path dependency is unshippable without a version req. We have to choose between:
- Path and version in workspace toml
- Dependency packages will be frozen until dependents ship against workspace version
- Path and version in dependents
- Dependents will be responsible for keeping their version in sync
- Path only in dependents
- Version can be fixed up at release time
- Will have to solve for tomlyn mangling of toml (either use rust or regex?)
There was a problem hiding this comment.
But I thought we can put both the path and version in the workspace Cargo.toml. I do not want to keep track of all the versions in the crates' Cargo.tomls. Most other languages use centralized versions/dependencies as well. It's far easier to keep track of and resolve CG alerts, etc.
